fix: wrap getCurrentChatDir in try-catch to prevent startup crash#788
Open
SOUMITRO-SAHA wants to merge 1 commit into
Open
fix: wrap getCurrentChatDir in try-catch to prevent startup crash#788SOUMITRO-SAHA wants to merge 1 commit into
SOUMITRO-SAHA wants to merge 1 commit into
Conversation
The logger calls getCurrentChatDir() during early startup (triggered by fingerprint initialization), which tries to mkdir the chat directory. If the config directory hierarchy doesn't exist yet, this throws ENOENT and crashes the app since the call is in a fire-and-forget promise. Wrapping the call in try-catch (matching the existing pattern for getProjectRoot()) lets the logger gracefully skip file logging instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue #783