Skip to content

London | 26-ITP-May | Rhoda Ajiroba | Sprint 2 | Wireframe#1426

Open
codebyra wants to merge 8 commits into
CodeYourFuture:mainfrom
codebyra:feature/wireframe
Open

London | 26-ITP-May | Rhoda Ajiroba | Sprint 2 | Wireframe#1426
codebyra wants to merge 8 commits into
CodeYourFuture:mainfrom
codebyra:feature/wireframe

Conversation

@codebyra
Copy link
Copy Markdown

@codebyra codebyra commented Jun 8, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

This PR completes the wireframe task by adding the HTML structure, CSS grid layout, accessibility improvements, and validation fixes.

@netlify
Copy link
Copy Markdown

netlify Bot commented Jun 8, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit c5755ab
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/6a2635bf88eba80007f0aa3c
😎 Deploy Preview https://deploy-preview-1426--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 100 (no change from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 91 (🟢 up 5 from production)
PWA: -
View the detailed breakdown and full score reports
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@codebyra codebyra added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jun 8, 2026
@codebyra codebyra changed the title London | 26-ITP-May | Rhoda Ajiroba | Sprint 2 | Feature/wireframe London | 26-ITP-May | Rhoda Ajiroba | Sprint 2 | Wireframe Jun 8, 2026
@codebyra
Copy link
Copy Markdown
Author

codebyra commented Jun 8, 2026

@cjyuan please can you review my work?

@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Jun 8, 2026

  • To better match the wireframe, position the page title to match its position in the wireframe. There should also be a "short description" beneath the title.

  • Can you update the images and links to meet a requirement that the articles should have distinct images and links?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Jun 8, 2026
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also restore the "Changelist" header in the PR description? It's a level 2 header that looks like this:

Changelist


Your formatting is already very good. Using a formatter with "Format on Save" would save you time, ensure 100% consistency, and automatically
clean up things like trailing whitespace and unnecessary empty lines. This also helps keep Git diffs and pull requests cleaner by reducing
formatting-only changes, making it easier to review the actual code changes.

For more info about enabling "Format on save" option on VS Code, please refer to this guide.


Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Reviewed Volunteer to add when completing a review with trainee action still to take.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants