Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…moved to components
|
Left some minor comments....very good job overall! |
| <Image | ||
| alt={name} | ||
| src={`https:${logo.fields.file.url}`} | ||
| width={logo.fields.file.details.image.width} |
There was a problem hiding this comment.
Haven't look at the contentful entries yet, but make sure you either:
- mark the fields as required in the Contentful content model, or
- filter out broken entries in e.g. projects.filter(p => p?.logo?.fields?.file)
depending on which ones are optional vs required
There was a problem hiding this comment.
Double checked, the fields are required in Contentful.
I will probably still add the filter in case someone adds a draft image as a logo (as that is, for some reason, allowed). Thank you.
| import Heading from '../../components/Heading'; | ||
| import Timeline from '../../components/Timeline'; | ||
| import { FAQS } from '../../data/faq'; | ||
| //import { FAQS } from '../../data/faq'; |
There was a problem hiding this comment.
I think we can go ahead and delete these imports along with the data files themselves. Git history preserves the old version if we ever need it.
There was a problem hiding this comment.
I will do that, thank you.
| <Carousel navigation={{ prevEl: '.swiper-button-prev', nextEl: '.swiper-button-next', clickable: true }}> | ||
| {ROLE.map((role) => ( | ||
| {roles.map((role) => ( | ||
| <SwiperSlide key={role.name}> |
There was a problem hiding this comment.
Fields like role.name rely on no duplicates, so make sure the fields are set to unique on contentful
Also added filtering to data fetched and sent to Events.jsx, ProjectsSection.jsx, RolesCarousel.jsx
|
There's two objects in join.js (JOIN_ONE and JOIN_TWO), it would be nice if we could move those to contentful as well We can also get rid of all the data files that are no longer in use |
1. When checking validity of image (filtering), it now checks the url 2. JOIN_ONE and JOIN_TWO data has been migrated to Contentful 3. Redundant data in data folders has been deleted (images has not been deleted for fear of unaccounted for dependency)
|
Re-commenting the changes mentioned in the commit message: 3 changes have been made
|
2 participants
Added fetching FAQS from the Contentful API.