SSF-235 User Deactivation & Activation Frontend#204
Merged
Conversation
jiang-h-y
approved these changes
Jul 4, 2026
jiang-h-y
left a comment
There was a problem hiding this comment.
Looks good, just a few small things! Also waiting on checks to pass (I think they're just missing the active field)
Yurika-Kan
reviewed
Jul 4, 2026
Collaborator
There was a problem hiding this comment.
notes:
- as admin, admin user's own account should not show up in user management page - that way admin cannot deactivate their own account. we would have to pass the requester in volunteers.controller getAllVolunteers() and then exclude self in the service
- right now from user management page, when we deactivate a volinteer and try to see their assigned pantries, it goes to tha pnantry management page and it errors saing that this volunteer has no assigned pantries. can we make the behavior same as a active user so that we can still show the user's assigned pantries regardless of their status?
side note:
- could you auth gate @get(‘/:id/pantries’) to also allow admin?
Yurika-Kan
requested changes
Jul 4, 2026
Yurika-Kan
approved these changes
Jul 6, 2026
Yurika-Kan
left a comment
Collaborator
There was a problem hiding this comment.
LGTM~ one small fixer upper then good to merge!
tested w diff accounts, smoke tested pages, comments all addressed #osm
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes https://vidushimisra.atlassian.net/jira/software/projects/SSF/boards/1?selectedIssue=SSF-235
📝 Description
Frontend functionality for deactivating and reactivating users.
✔️ Verification
Verified tests passed, functionality on frontend works, match with figma design
🏕️ (Optional) Future Work / Notes
N/A