Skip to content

SSF-235 User Deactivation & Activation Frontend#204

Merged
Juwang110 merged 7 commits into
mainfrom
jw/ssf-235-user-active-frontend
Jul 6, 2026
Merged

SSF-235 User Deactivation & Activation Frontend#204
Juwang110 merged 7 commits into
mainfrom
jw/ssf-235-user-active-frontend

Conversation

@Juwang110

Copy link
Copy Markdown

ℹ️ Issue

Closes https://vidushimisra.atlassian.net/jira/software/projects/SSF/boards/1?selectedIssue=SSF-235

📝 Description

Frontend functionality for deactivating and reactivating users.

  • Added filter in [Admin] Pantry Management to not show deactivated volunteers
  • Global rename from volunteer -> user management page
  • Added deactivate/activate buttons in User Management
  • New status column showing active/deactivated
  • Toast message for when a deactivated user logs in

✔️ Verification

Verified tests passed, functionality on frontend works, match with figma design

Screenshot 2026-07-01 145539 Screenshot 2026-07-01 145600

🏕️ (Optional) Future Work / Notes

N/A

@jiang-h-y jiang-h-y self-requested a review July 2, 2026 01:58
@Yurika-Kan Yurika-Kan self-requested a review July 3, 2026 21:54

@jiang-h-y jiang-h-y left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, just a few small things! Also waiting on checks to pass (I think they're just missing the active field)

Comment thread apps/backend/src/pantries/pantries.service.ts
Comment thread apps/frontend/src/containers/volunteerManagement.tsx Outdated
Comment thread apps/frontend/src/containers/userManagement.tsx

@Yurika-Kan Yurika-Kan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

notes:

  • as admin, admin user's own account should not show up in user management page - that way admin cannot deactivate their own account. we would have to pass the requester in volunteers.controller getAllVolunteers() and then exclude self in the service
  • right now from user management page, when we deactivate a volinteer and try to see their assigned pantries, it goes to tha pnantry management page and it errors saing that this volunteer has no assigned pantries. can we make the behavior same as a active user so that we can still show the user's assigned pantries regardless of their status?

side note:

  • could you auth gate @get(‘/:id/pantries’) to also allow admin?

@Yurika-Kan Yurika-Kan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

  • requested changes!

Comment thread apps/frontend/src/components/forms/assignVolunteersModal.tsx Outdated
Comment thread apps/frontend/src/containers/userManagement.tsx
@Juwang110 Juwang110 requested a review from Yurika-Kan July 5, 2026 17:13

@Yurika-Kan Yurika-Kan left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~ one small fixer upper then good to merge!

tested w diff accounts, smoke tested pages, comments all addressed #osm

Comment thread apps/frontend/src/containers/adminPantryManagement.tsx
@Juwang110 Juwang110 merged commit 7152b73 into main Jul 6, 2026
4 checks passed
@Juwang110 Juwang110 deleted the jw/ssf-235-user-active-frontend branch July 6, 2026 16:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants