[SSF 239] - Edit/Delete Orders Frontend#202
Merged
Merged
Conversation
Yurika-Kan
requested changes
Jul 3, 2026
Yurika-Kan
left a comment
Yurika-Kan
left a comment
Collaborator
There was a problem hiding this comment.
pretty darn great! hefty but mighty.
addressed a calculation bug & nit frontend things~
Juwang110
approved these changes
Jul 5, 2026
Juwang110
left a comment
Juwang110
left a comment
There was a problem hiding this comment.
Looks great to me! Just one small design thing
| [OrderStatus.SHIPPED]: [], | ||
| [OrderStatus.PENDING]: [], | ||
| [OrderStatus.DELIVERED]: [], | ||
| [OrderStatus.CLOSED]: [], |
There was a problem hiding this comment.
I'm thinking it's a good idea for the closed section title to have a different bg color than Received, though not sure what that color could be.
Yurika-Kan
approved these changes
Jul 6, 2026
Yurika-Kan
left a comment
Yurika-Kan
left a comment
Collaborator
There was a problem hiding this comment.
LGTM!
tested as volunteer, non volunteer, editing, adding, deleting items + errors
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ℹ️ Issue
Closes #239
📝 Description
✔️ Verification
🏕️ (Optional) Future Work / Notes
Pending clarification on if deleting/closing an order is the same thing