[SSF-240] - Admin edit pantry details#201
Conversation
Yurika-Kan
left a comment
Yurika-Kan
left a comment
There was a problem hiding this comment.
tested via frontend through admin + pantry user
auth gating looks good~
tests look good~
needs attention: nit ux bug that pops up when loading
Yurika-Kan
left a comment
Yurika-Kan
left a comment
There was a problem hiding this comment.
bug that heidi found! pls address this & let's get that reviewed before mergington
problem: when you clear optional fields when editing Pantry application details, the changes aren’t saved
Here's the description: |
Yurika-Kan
left a comment
Yurika-Kan
left a comment
There was a problem hiding this comment.
some more findings hehe~
| }; | ||
| setApplication(updatedWithUser); | ||
| setForm(buildFormState(updatedWithUser)); | ||
| setAlertMessage('Changes successfully saved.', AlertStatus.INFO); |
There was a problem hiding this comment.
bug: success toast never shows~ this line is set on the child's own local useAlert state, then onEditingChange(false) unmounts the child before it can render. can we fix so that user gets a save confirmation?
| </Box> | ||
|
|
||
| {!isApplicationMode && isEditing ? ( | ||
| <EditablePantryApplication |
There was a problem hiding this comment.
rn we are passing pantryId alongside initialApplication, but the child only reads pantryId inside fetchApplication, which never runs when initialApplication is present. can we drop pantryid in this block?
4 participants
ℹ️ Issue
Closes https://vidushimisra.atlassian.net/browse/SSF-240
📝 Description
✔️ Verification
logged in as admin and tested editing feature on pantries
🏕️ (Optional) Future Work / Notes
none