docs(skills): stop hardcoding MCP tool schemas in the optimize skill#451
Merged
Conversation
Merging this PR will not alter performance
|
The codspeed-optimize skill hand-listed the CodSpeed MCP tools and their parameters, duplicating the live tool schemas the agent already has. That block had silently rotted: it advertised `benchmark_name` (renamed to `benchmark_uri`), a `depth_limit` parameter that no longer exists on `query_flamegraph`, and a top-level `root_function_name` (now under `filters`). Trim it to strategy and guidance and let the live tool schemas carry each tool's name, parameters, and behavior, so the skill can't tell the agent to call tools with stale arguments the next time the MCP surface changes. Refs COD-2567
bd9fa9b to
f149eec
Compare
adriencaccia
approved these changes
Jul 10, 2026
SuperMuel
approved these changes
Jul 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Trim the
codspeed-optimizeskill so it no longer hand-lists the CodSpeed MCP tools and their parameters, leaving strategy and guidance and letting the live tool schemas carry each tool's name, parameters, and behavior.The skill duplicated the MCP schema in two places (the "Analyze with flamegraphs" step and a "MCP tools reference" section), and it had silently rotted: it advertised
benchmark_name(renamed tobenchmark_uri), adepth_limitparameter that no longer exists onquery_flamegraph, and a top-levelroot_function_name(now nested underfilters). A skill that hardcodes stale arguments teaches the agent to call tools with parameters that get validated away.Follow-up to the MCP param rename where @adriencaccia flagged this skill as duplicating the MCP schema by hand.
Refs COD-2567