disable-pb-tb.ag by alexandergull · Pull Request #806 · CleanTalk/wordpress-antispam

alexandergull · 2026-06-04T08:49:41Z

https://app.doboard.com/1/task/50454

codecov · 2026-06-04T08:52:26Z

Codecov Report

❌ Patch coverage is 75.55556% with 11 lines in your changes missing coverage. Please review.
✅ Project coverage is 26.14%. Comparing base (af56aac) to head (b04c864).

Files with missing lines	Patch %	Lines
...alk/ApbctWP/PingbackTrackback/TrackBackHandler.php	50.00%	6 Missing ⚠️
cleantalk.php	33.33%	2 Missing ⚠️
inc/cleantalk-settings.php	60.00%	2 Missing ⚠️
...talk/ApbctWP/PingbackTrackback/PingbackHandler.php	92.85%	1 Missing ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##                dev     #806      +/-   ##
============================================
+ Coverage     26.05%   26.14%   +0.09%     
- Complexity     5621     5633      +12     
============================================
  Files           264      267       +3     
  Lines         24126    24171      +45     
============================================
+ Hits           6285     6319      +34     
- Misses        17841    17852      +11

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Copilot

Pull request overview

This PR introduces an optional setting to disable incoming Pingback and Trackback requests (commonly abused for spam) while keeping XML-RPC available for other integrations.

Changes:

Added a new plugin setting (wp__disable_pingback_and_trackback) and exposed it in the admin settings UI with a long description view.
Implemented PingbackHandler (XML-RPC pingback method interception) and TrackbackHandler (blocks trackback endpoint processing).
Added PHPUnit coverage for PingbackHandler.

Reviewed changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Show a summary per file

File	Description
tests/ApbctWP/PingbackTrackback/TestPingbackHandler.php	Adds unit tests validating pingback method replacement and error response.
lib/Cleantalk/ApbctWP/State.php	Introduces default setting flag for disabling pingbacks/trackbacks.
lib/Cleantalk/ApbctWP/PingbackTrackback/TrackbackHandler.php	Adds hook-based trackback blocking handler (currently has PHP compatibility/callback signature issues).
lib/Cleantalk/ApbctWP/PingbackTrackback/SettingsView.php	Provides title/description/long description text for the new setting.
lib/Cleantalk/ApbctWP/PingbackTrackback/PingbackHandler.php	Adds XML-RPC pingback blocking handler returning `IXR_Error`.
inc/cleantalk-settings.php	Registers the new setting field and its long-description payload.
cleantalk.php	Instantiates pingback/trackback handlers on `init` when the new setting is enabled.

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 7 out of 7 changed files in this pull request and generated 4 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 1 comment.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot

Pull request overview

Copilot reviewed 8 out of 8 changed files in this pull request and generated 3 comments.

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 2 comments.

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

…b-tb.ag

Copilot

Pull request overview

Copilot reviewed 9 out of 9 changed files in this pull request and generated 1 comment.

AntonV1211

👍

alexandergull added 2 commits June 4, 2026 13:40

New. Pingback and trackback rejection implemented.

a4ec1c9

Upd. Pingback and trackback. Tests added.

65e3d58

Copilot AI review requested due to automatic review settings June 4, 2026 08:49

Copilot started reviewing on behalf of alexandergull June 4, 2026 08:49 View session

Copilot AI reviewed Jun 4, 2026

View reviewed changes

Comment thread lib/Cleantalk/ApbctWP/PingbackTrackback/TrackbackHandler.php Outdated

Comment thread lib/Cleantalk/ApbctWP/PingbackTrackback/TrackbackHandler.php Outdated

Comment thread lib/Cleantalk/ApbctWP/PingbackTrackback/TrackBackHandler.php

Comment thread inc/cleantalk-settings.php Outdated

CP. Fixing pre_trackback_post args.

5f34edb

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 4, 2026 08:55

Copilot started reviewing on behalf of alexandergull June 4, 2026 08:55 View session

alexandergull and others added 2 commits June 4, 2026 13:56

CP. Removed unused usage.

f78035a

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Fix. PHPCS.

035ded2

Copilot AI reviewed Jun 4, 2026

View reviewed changes

Comment thread tests/ApbctWP/PingbackTrackback/TestPingbackHandler.php

Comment thread inc/cleantalk-settings.php Outdated

Comment thread lib/Cleantalk/ApbctWP/PingbackTrackback/TrackBackHandler.php

Comment thread lib/Cleantalk/ApbctWP/PingbackTrackback/TrackBackHandler.php

alexandergull and others added 4 commits June 4, 2026 14:02

CP. Method call args fixed.

882faec

CP. Use correct escape without localization.

a2cc8f7

CP. New unit added for TrackBack handler.

4bfee6c

CP. Unit text. IXR Error class forced.

bc78bdb

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 4, 2026 09:07

Copilot started reviewing on behalf of alexandergull June 4, 2026 09:07 View session

Copilot AI reviewed Jun 4, 2026

View reviewed changes

Comment thread lib/Cleantalk/ApbctWP/PingbackTrackback/PingbackHandler.php

CP. Precheck if XMLRPC method is not unset by other plugins/core.

aa17951

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 4, 2026 09:15

Copilot started reviewing on behalf of alexandergull June 4, 2026 09:15 View session

Copilot AI reviewed Jun 4, 2026

View reviewed changes

Comment thread inc/cleantalk-settings.php

Comment thread inc/cleantalk-settings.php

Comment thread tests/ApbctWP/PingbackTrackback/TestTrackBackHandler.php

alexandergull added 2 commits June 4, 2026 14:21

Upd. PHPUnit. PingbackTrackback\SettingsView

8754803

CP. Fixed spaces.

65053c4

Copilot AI review requested due to automatic review settings June 4, 2026 09:22

Copilot started reviewing on behalf of alexandergull June 4, 2026 09:22 View session

CP. Fixed camel cases.

209054b

Copilot AI reviewed Jun 4, 2026

View reviewed changes

Comment thread lib/Cleantalk/ApbctWP/PingbackTrackback/PingbackHandler.php Outdated

Comment thread tests/ApbctWP/PingbackTrackback/TestSettingsView.php Outdated

CP. Test. rename function.

039a6fa

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Copilot AI review requested due to automatic review settings June 4, 2026 09:29

Copilot started reviewing on behalf of alexandergull June 4, 2026 09:29 View session

alexandergull and others added 4 commits June 4, 2026 14:29

CP. Args added to the method call.

f6fbc9a

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

CP. Args added to the method call.

2293c99

Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>

Fix. Syntax.

f729078

Merge remote-tracking branch 'origin/disable-pb-tb.ag' into disable-p…

b04c864

…b-tb.ag

Copilot AI reviewed Jun 4, 2026

View reviewed changes

Comment thread tests/ApbctWP/PingbackTrackback/TestSettingsView.php

alexandergull requested review from AntonV1211, Glomberg and svfcode June 4, 2026 09:36

Glomberg approved these changes Jun 5, 2026

View reviewed changes

AntonV1211 approved these changes Jun 5, 2026

View reviewed changes

svfcode approved these changes Jun 6, 2026

View reviewed changes

Conversation

alexandergull commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov Bot commented Jun 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

AntonV1211 left a comment

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

alexandergull commented Jun 4, 2026 •

edited

Loading

codecov Bot commented Jun 4, 2026 •

edited

Loading