fix#114
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR adjusts DoBoard widget UI logic to better handle “system” users and to avoid marking spots as “lost” when viewing tasks that belong to a different page URL.
Changes:
- Hide the logged-user name block for internal
spotfix_accounts. - Only treat a missing
nodePathreference as “not relevant / lost link” when the task’spageURLmatches the current page. - Update the built
dist/doboard-widget-bundle.jsto reflect source changes.
Reviewed changes
Copilot reviewed 1 out of 4 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| js/src/widget.js | Updates UI conditions for logged user display and “lost reference” detection. |
| dist/doboard-widget-bundle.js | Bundled output updated to match the source logic changes. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+887
to
889
| if(localStorage.getItem('spotfix_session_id') && !(localStorage.getItem('spotfix_email')?.includes('spotfix_'))) { | ||
| loggedUserNameBlock.style.display = 'flex'; | ||
| } else loggedUserNameBlock.style.display = 'none'; |
Glomberg
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.