Pin jsonschema>=4.18 in requirements.txt#1
Open
camlloyd wants to merge 1 commit into
Open
Conversation
validate_evidence relies on Draft202012Validator (added in jsonschema 4.18.0). Without a pin, an older jsonschema installs the fail-closed validator catches the resulting ImportError as a schema error, causing 15 test failures across test_evidence_schema, test_score_acmg, and test_gradient_runner. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
validate_evidencerelies onDraft202012Validator(added in jsonschema 4.18.0). Without a pin, an older jsonschema installs and the fail-closed validator catches the resultingImportErroras a schema error, causing 15 test failures acrosstest_evidence_schema,test_score_acmg, andtest_gradient_runner.Test plan
pip install -r requirements.txton a clean env and confirm jsonschema>=4.18 is installedtest_evidence_schema,test_score_acmg,test_gradient_runnerand confirm they pass