feat(settings): add /settings and move the dashboard onto a sidebar - #911
Merged
Merged
Conversation
…ications, API keys and security into it Work in progress: MainNav, link updates, rules/docs and test updates still pending.
…the move - MainNav: account menu gets Settings and loses Membership, API & Dev Tools and the language picker; signed-out header gets a globe link to /settings/preferences; drawer gets Dashboard and Settings. - AccountSignInGate shared by /dashboard and /settings; the AccountShell nav-footer now shows below lg too. - /settings/membership waits for the profile before choosing member or join. - useCurrency: a choice made while the profile read is in flight wins. - Repoint /dashboard/api-keys and /dashboard/notifications references, the listing wizard's change-currency link, EMAILED_PATHS, route crawler expectations, rules (new account-settings.md) and invariants. - Tests: ManageCard suite split out of membership.test.ts; new shell, gate, settings page, currency select and currency race tests; E2E specs drive the language switch through /settings/preferences.
SomethingNew71
added a commit
that referenced
this pull request
Sep 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
/settingspage, open to every visitor:preferences(public): language and currency. It is the only language and currency control on the site.membership: the member-management card, extracted from/membership.notifications: moved from/dashboard. It stays behind the marketplace flag.api-keys: moved from/dashboard.security: passkeys and the delete-account link, moved from/profile/edit./dashboarduses a grouped sidebar (<AccountShell>) instead of the 12-tab strip./dashboardand/settingsshare one sign-in gate (<AccountSignInGate>)./settings/preferences./membershipstays the public sales and checkout page. Members see a link to/settings/membership.initUserCurrencywas never called). A choice made while the profile read is in flight wins./dashboard/api-keysand/dashboard/notifications301 to/settings/*. These redirects are permanent: transactional emails and the MCP README link to the old paths.Design:
docs/plans/2026-09-28-settings-page-and-dashboard-sidebar.md. Rules:.claude/rules/account-settings.md.Test plan
bun run test: 6413 / 6413 pass. New tests cover the shell, the gate, the settings page, the membership section, the currency select and the currency race.NITRO_PRESET=cloudflare_module bun run buildsucceeds./settingsreturns 302 to preferences.i18n_redirected=de).After merge
scripts/sync-tme-zone-redirects.py. The TME/settings/*targets changed.classicminidiy-supabase, repoint the email links to/settings/notifications.🤖 Generated with Claude Code