fix(membership): return to /membership/youtube without a query string - #910
Merged
Merged
Conversation
Supabase matches linkIdentity's redirectTo against the Redirect URLs allowlist as a whole address, so '?linked=1' failed the exact entry and the user landed on the Site URL with an unused code. The returned code/error_code already mark the return.
Without ?linked=1 the return carries only ?code=; the sync ran only on 'linked', so the page linked Discord but never checked the level.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linking Discord at
/membership/youtubesent Cole to the home page with an unused?code=. The Discord identity was still linked (confirmed inauth.identities).Cause: Supabase matches
redirectToagainst the Redirect URLs allowlist as a whole address.…/membership/youtube?linked=1did not match the exact entry…/membership/youtube, so GoTrue fell back to the Site URL.Fix:
redirectTono longer has a query string. The page already treats a returnedcodeorerror_codeas the return. The tests now return with?code=alone. 34 page tests pass, typecheck is at baseline, and the format check is clean.🤖 Generated with Claude Code