fix test array values - #232
robbtraister wants to merge 1 commit into
Conversation
|
@kroenlein do you have any advice on how to handle this PR? It feels odd to do a version bump for a test syntax bugfix. |
| "3 rpm", # No leading digits | ||
| "16", # No values that are just integers | ||
| "16.2" # No values that are just floats | ||
| "16.2", # No values that are just floats |
There was a problem hiding this comment.
Whoever thought auto-concatenate across lines was a good idea should not be allowed to touch a keyboard.
|
@robbtraister says
Formally, you could do a force merge. Since this is a testing issue not a code issue, the fact that someone might have the "wrong" commit installed shouldn't be a problem and a developer should always be working off main regardless. This isn't something we'd release for. I don't see harm in a patch bump, but won't be bothered if it doesn't move. |
|
I have an unrelated feature proposal on my local that justifies a minor version bump. I could roll it into that. |
GEMD Python PR
Description
Fix test values. Without this comma, adjacent string values are concatenated into a single string element in the array.
PR Type:
Adherence to team decisions