Skip to content

fix test array values - #232

Open
robbtraister wants to merge 1 commit into
mainfrom
test-values
Open

robbtraister wants to merge 1 commit into
mainfrom
test-values

Conversation

@robbtraister

Copy link
Copy Markdown

GEMD Python PR

Description

Fix test values. Without this comma, adjacent string values are concatenated into a single string element in the array.

PR Type:

  • Breaking change (fix or feature that would cause existing functionality to change)
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Maintenance (non-breaking change to assist developers)

Adherence to team decisions

  • I have added tests for 100% coverage
  • I have written Numpy-style docstrings for every method and class.
  • I have communicated the downstream consequences of the PR to others.
  • I have bumped the version in __version__.py

@robbtraister

Copy link
Copy Markdown
Author

@kroenlein do you have any advice on how to handle this PR? It feels odd to do a version bump for a test syntax bugfix.

@kroenlein kroenlein left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch.

"3 rpm", # No leading digits
"16", # No values that are just integers
"16.2" # No values that are just floats
"16.2", # No values that are just floats

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoever thought auto-concatenate across lines was a good idea should not be allowed to touch a keyboard.

@kroenlein

kroenlein commented Sep 10, 2026

Copy link
Copy Markdown
Collaborator

@robbtraister says

@kroenlein do you have any advice on how to handle this PR? It feels odd to do a version bump for a test syntax bugfix.

Formally, you could do a force merge. Since this is a testing issue not a code issue, the fact that someone might have the "wrong" commit installed shouldn't be a problem and a developer should always be working off main regardless. This isn't something we'd release for. I don't see harm in a patch bump, but won't be bothered if it doesn't move.

@robbtraister

Copy link
Copy Markdown
Author

I have an unrelated feature proposal on my local that justifies a minor version bump. I could roll it into that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants