Skip to content

Issues with the JOSS paper #142

Description

@svisak

Here I'll collect my comments on the manuscript for the JOSS review.

First, the manuscript is quite old by now (last commit was 2 years ago), so I recommend going over it in general and see if new developments, yours or others, should be included. Some references have been published since the last revision.

The manuscript mentions an MIT license, but the LICENSE file is GPL.

I wouldn't call the piecewise polytrope or speed of sound models "metamodels". A metamodel typically indicates an expansion in terms of physical properties of nuclear matter at saturation density.

"Many of these studies such as (Raaijmakers et al., 2023) focus on EOS meta-models [...] rather than being driven by microphysics." Please forgive a slight bias on my part here, as I'm involved in the mentioned study, but I don't think it's correct to say that it is not driven by microphysics, as ab initio nuclear matter calculations based on chiral EFT forms an important part of that framework. I think the benefits of CompactObject can be highlighted without that statement.

Some references are not using the proper syntax, such as one place where "\citep" is visible in the PDF.

Otherwise the manuscript reads well.

Activity

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions