Repository navigation
Conversation
…ristianHandy#225) Signed-off-by: Milan-CSE <milannakum.ce22@sltiet.edu.in>
ChristianHandy
requested changes
Oct 23, 2026
ChristianHandy
left a comment
ChristianHandy
left a comment
Owner
There was a problem hiding this comment.
Thanks @Milan-CSE, ne question: your "AI assistance" section only says "I reviewed and tested the changes". Did you use any AI tools? If not, please change it to "No AI tools were used", otherwise say which ones.
ChristianHandy
added
no changelog
Contributor
🔴 Not ready to merge
Commit What this pull request changes1 files, +520 / -0 lines.
Changed files
Required checks
Other checks: 11 passed, 0 failed, 1 running. How to fix
|
ChristianHandy
added a commit
that referenced
this pull request
Oct 23, 2026
## Summary
pip-audit ("Check dependencies for known vulnerabilities") fails the
pytest jobs on every pull request (e.g. #246): brotli 1.2.0 has
PYSEC-2026-4322, fixed in 1.2.1.
## Changes
- `requirements-lock.txt`: brotli 1.2.0 → 1.2.1, regenerated with `uv
pip compile ... --upgrade-package brotli` (no other package changes; the
dev lock has no brotli pin of its own).
- `CHANGELOG.md`: entry under Unreleased → Security.
## Verification
- `pip-audit --require-hashes --disable-pip -r requirements-lock.txt` →
no known vulnerabilities
- same for `requirements-dev-lock.txt` → no known vulnerabilities
## AI assistance
Prepared with Claude Code.
🤖 Generated with [Claude Code](https://claude.com/claude-code)
Signed-off-by: ChristianHandy <christianhandy180@gmail.com>
Co-authored-by: ChristianHandy <christianhandy180@gmail.com>
Co-authored-by: Claude Opus 5.5 <noreply@anthropic.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes for users
Adds unit tests for the remote disk plugin's SSH helpers and API routes (
addons/remote_disk_plugin.py), covering remote command execution, disk listing, SMART information, disk formatting, SMART tests, and route permissions with mocked SSH interactions.Closes #225
How it was tested
python -m pytest tests/test_remote_disk_routes.py tests/test_remote_disk_plugin.py -q: 54 passedpython -m coverage run -m pytest -q tests/test_remote_disk_routes.py tests/test_remote_disk_plugin.py && python -m coverage report --include=addons/remote_disk_plugin.py: 98.2% coverageruff check .: passedpython -m pytest tests/test_license_headers.py: passedpython scripts/pr_threat_scan.py upstream/main HEAD: passedChecklist
python -m pytest -qandruff check .pass; coverage has not dropped.git commit -s, using the commit author's email address (DCO).CHANGELOG.mdupdated under Unreleased if users notice the change. (N/A: test-only change)AI assistance
I reviewed and tested the changes.