Repository navigation
fix(wayland): add downgrade path for Mutter compositor, correct READM… - #6
Merged
Merged
Conversation
Owner
|
请问您使用的模型是，让我看看有没有让 Opus 大人审查的必要（ |
Contributor
Author
使用 Kimi K3 |
Owner
|
好的，我会在修好 CI 并稍作审查后合并 |
…er shell Localize the overlay window title, which the fallback now shows in the window switcher, and keep it in sync with the language. Share the cursor reset between both drag paths, drop a guard the fallback can never reach, and document what the fallback gives up in README and AGENTS.md. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Owner
|
十分感谢您的贡献！ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The Mutter compositor GNOME uses actually doesn't support layer-shell protocol, and its developer explicitly refuses to add support (ref: layer-shell protocol support ). This PR adds downgrade path for it so that basic functions would work properly, plus corrected README.md.
NOTE: To enable Always On Top in GNOME, press
Alt + Spaceon the window and select Always On Top option. It's also good to turn on Always on Visible WorkspaceScreenshot
Validation
Tested that this modification works on my Fedora Workstation 44 (GNOME 50.5, Wayland)
Ran
GNOME 用的 Mutter 合成器不支持 layer-shell 且这家伙也不想支持这个协议（参见 layer-shell protocol support）。于是提了个 PR 提供了一个降级路径，让这个程序能正常工作，窗口能正常拖动，顺带更新了一下 README 的一些描述。
在我的 Fedora Workstation 44 （GNOME 50.5, Wayland） 环境下测试通过，工作正常。
需要注意的是，由于降级路径和 GNOME 限制，想让歌词始终置顶，最好在歌词窗口上按下键盘的
Alt + Space然后打开 "始终置于顶层" 和 "始终在所有工作区可见"