Skip to content

feat: add support for plugins to disable account description - #7769

Open
kontrollanten wants to merge 4 commits into
Chocobozzz:developfrom
kontrollanten:feat/7768-hide-desc
Open

feat: add support for plugins to disable account description #7769
kontrollanten wants to merge 4 commits into
Chocobozzz:developfrom
kontrollanten:feat/7768-hide-desc

Conversation

@kontrollanten

Copy link
Copy Markdown
Contributor

Description

Add support for plugins to disable account description. Also added plugin selector to username description.

Related issues

closes #7768

Has this been tested?

  • 👍 yes, I added tests to the test suite

Screenshots

<label i18n for="username">Username</label>
<input type="text" id="username" class="form-control" formControlName="username" readonly>
<div class="form-group-description" i18n>
<div id="plugin-selector-profile-username-description" class="form-group-description" i18n>

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use myPluginSelector directive

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure! Maybe a better name is profile-form-username-description?

withEmoji="true"
withHtml="true"
></my-markdown-textarea>
<div id="plugin-selector-profile-description">

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would make more sense to have this plugin selector in the form-group div above no?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure. It's the textarea that we're interested in, but we can put the selector at a higher level.

@kontrollanten

Copy link
Copy Markdown
Contributor Author

A more consistent way of solving this would be to add profile-form-[name]-field-group to username and description. Then we could select their children with .form-group-description and textarea selectors. But that depends on that those selectors will be stable during updates, do you have any thoughts about this?

@kontrollanten

Copy link
Copy Markdown
Contributor Author

A more consistent way of solving this would be to add profile-form-[name]-field-group to username and description. Then we could select their children with .form-group-description and textarea selectors. But that depends on that those selectors will be stable during updates, do you have any thoughts about this?

I updated the PR according to this comment. Please let me know what you think.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Plugin ability to disable account description

2 participants