Skip to content

transcode all resolutions from original source if possible - #7605

Open
ac615223s5 wants to merge 5 commits into
Chocobozzz:developfrom
ac615223s5:transcode-only-once
Open

transcode all resolutions from original source if possible#7605
ac615223s5 wants to merge 5 commits into
Chocobozzz:developfrom
ac615223s5:transcode-only-once

Conversation

@ac615223s5

@ac615223s5 ac615223s5 commented May 13, 2026

Copy link
Copy Markdown

Description

if keep original file is enabled, use the original file for transcoding to other resolutions

Related issues

Has this been tested?

  • 👍 yes, I added tests to the test suite
  • 💭 no, because this PR is a draft and still needs work
  • 🙅 no, because this PR does not update server code
  • 🙋 no, because I need help

Screenshots

sunshine and others added 5 commits May 12, 2026 17:53
Drive a transcode with keepOriginal on and assert the server logs the
"Using kept original file" line tagged with the video UUID. Mirror with
keepOriginal off to confirm the message is absent.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
fluent-ffmpeg validates the format string against ffmpeg's canonical
muxer names. The mkv extension maps to muxer "matroska", so passing
"mkv" to .format() fails the capability check and aborts the run.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
Without save/rollback, the keep-original setting from the new describe
block leaked into "Should replace the video with an audio only file",
which then transcoded new resolutions from the audio-only replacement
source and produced 3 files instead of the expected 8.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
If the latest source has been replaced with an audio-only file, the
kept-original path holds no decodable video. Using it as the transcoding
input then fails every video-resolution job (and the matching runner
flows), so the system falls back to the previous max-quality file in
that case.
a

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@Chocobozzz

Copy link
Copy Markdown
Owner

Is it still a draft?

@ac615223s5
ac615223s5 marked this pull request as ready for review June 15, 2026 21:18
@ac615223s5

Copy link
Copy Markdown
Author

it is working for me but I have not not looked through all of the code yet

@Chocobozzz

Copy link
Copy Markdown
Owner

Any news on this PR?

@frenzybiscuit

Copy link
Copy Markdown

Any update on this PR? Would love to see this implemented.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Status: Waiting for answer Waiting issue author answer

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants