Skip to content

allow others to download original file - #7604

Open
ac615223s5 wants to merge 3 commits into
Chocobozzz:developfrom
ac615223s5:allow-others-to-download-original-file
Open

allow others to download original file#7604
ac615223s5 wants to merge 3 commits into
Chocobozzz:developfrom
ac615223s5:allow-others-to-download-original-file

Conversation

@ac615223s5

@ac615223s5 ac615223s5 commented May 13, 2026

Copy link
Copy Markdown

Description

if keep original file is enabled and the uploader enables it for the video

Related issues

fix #6698

Has this been tested?

  • 👍 yes, I added tests to the test suite
  • 💭 no, because this PR is a draft and still needs work
  • 🙅 no, because this PR does not update server code
  • 🙋 no, because I need help

Screenshots

sunshine and others added 2 commits May 12, 2026 17:53
Cover the default-off state, owner-side update of the flag, a non-owner
gaining access to both getSource and the original-file download once the
owner opts in, and the access being revoked again on disable.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@ac615223s5
ac615223s5 marked this pull request as ready for review May 21, 2026 22:33

@Chocobozzz Chocobozzz left a comment

Copy link
Copy Markdown
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please:

  • Add config existence check in server/core/initializers/checker-before-init.ts
  • Also check config consistency in server/core/initializers/checker-after-init.ts to ensure download enabled is true if download_original_file_enabled is true
  • Update production.yaml.example with the new config
  • Support federation so other instances can also provide original file download

Comment thread server/core/middlewares/validators/videos/videos.ts
Comment thread server/core/middlewares/validators/shared/videos.ts
Add config existence check in server/core/initializers/checker-before-init.ts
Also check config consistency in server/core/initializers/checker-after-init.ts to ensure download enabled is true if download_original_file_enabled is true
Update production.yaml.example with the new config
@ac615223s5

Copy link
Copy Markdown
Author

I have made most of the changes, but federation support is beyond my current understanding.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

option for everyone to download the original video file

2 participants