Skip to content

deliver NEXT_PUBLIC_SF_SITE_URL to the published image - #26

Merged
Cho-Geer merged 6 commits into
developfrom
feat/sf-site-url-build-arg
Sep 22, 2026
Merged

Cho-Geer merged 6 commits into
developfrom
feat/sf-site-url-build-arg

Conversation

@Cho-Geer

Copy link
Copy Markdown
Owner

背景(PR #25 の後続修正)

PR #25 で ARG/build-args を導入したが、develop イメージには URL が焼き込まれていなかった:

  1. build-args が test-image-push ジョブにのみ付与され、publish する本体の build-and-push ジョブに無かった
  2. 記法がコロン形式で、build-push-action が期待する KEY=VALUE と不一致(ARG 名が不正)
  3. test-image-push の build で platforms(マルチアーキ)と load: true が併存し、即死

変更

  • 本体 build-and-push ステップに build-args を追加(vars.NEXT_PUBLIC_SF_SITE_URL・KEY=VALUE 形式)
  • test-image-push ステップ: platforms を削除 + KEY=VALUE 形式に修正

マージ後の確認

  • CI 全緑(test-image-push を含む)
  • pull frontend → up -d --force-recreate frontend
  • chunk に my.site.com が焼き込まれたことを grep で確認
  • 管理画面強制リロード → Salesforce 管理ワークベンチ ボタン有効

TraeAI added 5 commits September 23, 2026 00:52
- * text=auto eol=lf: all text files stored & checked out as LF
- common binary patterns marked binary (no EOL conversion)
- LICENSE blob renormalized CRLF->LF (EOL-only, no content change)
@Cho-Geer Cho-Geer self-assigned this Sep 22, 2026
@Cho-Geer Cho-Geer added bug Something isn't working CI/CD labels Sep 22, 2026
@Cho-Geer
Cho-Geer merged commit 7e0f83a into develop Sep 22, 2026
5 checks passed
@Cho-Geer
Cho-Geer deleted the feat/sf-site-url-build-arg branch September 26, 2026 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working CI/CD

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants