chore: merge develop into master for production deployment readiness - #3
Merged
Merged
Conversation
- Create .github/workflows directory with verify-deployment.yml and verify-images.yml - Update .gitignore to implement documentation management strategy - Configure .gitignore to ignore most docs while preserving core documentation files - Add specific exceptions for devops-ci-cd-assessment-and-remediation-plan.md and devops-runbook.md
- Move build-all-images.ps1 to scripts directory - Add build-all-images.sh Bash version for Linux/Mac - Update relative paths for script relocation - Centralize all deployment scripts for consistency
- Add pull_request trigger to verify-images.yml - Ensure branch protection requirements can be met for PRs - Match trigger configuration with verify-deployment workflow - Enable image verification checks on pull requests to master/develop This fixes the issue where verify-images status check was required but never ran on pull requests, blocking PR merges.
Enhance image verification script to auto-generate missing env files and inject secrets based on environment.
Added environment variables for image verification.
…king-deploy into feat/devops-cicd-foundation
…Geer/booking-deploy into feat/devops-cicd-foundation
Remove condition to log in to Docker Hub for all events.
Feat/devops cicd foundation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📋 Summary
Merge deployment verification workflow optimizations, environment template fixes, and security enhancements from
developintomaster.🔧 Key Changes
verify-images.ymlnow dynamically generates environment files and injects Secretsdevenvironment now correctly uses thedeveloptagfail-fast: falseto prevent matrix strategy cancellation{{DOCKER_HUB_USER}}placeholder instead of hardcoded usernames.exampletemplates✅ Verification
verify-imagesworkflow on thedevelopbranch fully passes for bothdevandprodenvironments📦 Impact
masterbranch will use themaintag for production environment verification (effective once the backend and frontendmasterbranches have pushed the corresponding images).🔗 Related
booking-backendandbooking-frontendbeing merged tomasterfirst.