Repository navigation
fix: only chmod the nitro binary right after extracting it - #1
Merged
Merged
Conversation
There was a problem hiding this comment.
🟢 Approval recommended
The change is small, locally contained, and directly addresses the reported failure mode without altering the cache-hit behavior beyond removing the failing chmod step.
Pull request overview
This PR adjusts installNitro to avoid attempting to chmod +x a Nitro binary when it was retrieved from the shared GitHub Actions tool cache, preventing failures on self-hosted runners where the cached binary may be owned by a different user (e.g., root from a container job).
Changes:
- Move
chmod +xso it only runs immediately after extracting and caching a newly downloaded Nitro release. - Leave tool-cache hits untouched to avoid
EPERM/“Operation not permitted” failures on shared self-hosted runner caches.
File summaries
| File | Description |
|---|---|
src/index.ts |
Restricts chmod +x to the fresh-download path to avoid failing on cache hits with mismatched file ownership. |
Review details
- Files reviewed: 1/1 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
installNitromarks the Nitro binary executable only in the download branch, right aftertc.cacheDir. A binary thattc.findreturns from the tool cache is left untouched.chmod +xthat followed every cache hit failed with "Operation not permitted". That failed every host-user job using any Nitro action on that runner until the cache entry was deleted by hand. The cached binary is always already executable, because the job that installed it ran this same chmod.Test plan
yarn install --immutableandtsc --noEmitpass.