Repository navigation
Record undeclared RabbitMQ dispatch targets in the topology under explicit binding - #10492
Closed
PascalSenn wants to merge 1 commit into
Closed
PascalSenn wants to merge 1 commit into
PascalSenn wants to merge 1 commit into
Conversation
PascalSenn
added this pull request to stack #10493
October 6, 2026 17:25
github-actions
Bot
added
📚 documentation
PascalSenn
removed this pull request from stack #10493
October 6, 2026 17:25
Contributor
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
It unnecessarily removes public compatibility properties and introduces exceptions outside the required ThrowHelper pattern.
Review effort: Balanced
Findings: 1
Open (2)
What changed in this PR
Records undeclared RabbitMQ dispatch targets in topology while preventing provisioning under explicit binding.
Changes:
- Adds non-provisioned queue/exchange topology resources.
- Resolves dispatch endpoints through topology destinations.
- Updates documentation and tests.
| File | Description |
|---|---|
website/content/docs/mocha/routing-and-endpoints.md |
Documents explicit-binding behavior. |
src/Mocha/test/Mocha.Transport.RabbitMQ.Tests/RabbitMQDispatchEndpointTests.cs |
Tests topology recording and destination resolution. |
src/Mocha/src/Mocha/Endpoints/DispatchEndpoint.cs |
Updates destination documentation. |
src/Mocha/src/Mocha.Transport.RabbitMQ/UriHelpers.cs |
Removes relocated topology parsing. |
src/Mocha/src/Mocha.Transport.RabbitMQ/Topology/RabbitMQRoutingStrategy.cs |
Creates unprovisioned topology targets. |
src/Mocha/src/Mocha.Transport.RabbitMQ/RabbitMQMessagingTransport.cs |
Matches endpoints through destination resources. |
src/Mocha/src/Mocha.Transport.RabbitMQ/RabbitMQDispatchEndpoint.cs |
Uses topology resources during dispatch. |
src/Mocha/src/Mocha.Transport.RabbitMQ/Descriptors/IRabbitMQDispatchEndpointDescriptor.cs |
Updates descriptor documentation. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
15
to
18
| /// <summary> | ||
| /// Gets the topology queue this endpoint targets, or <c>null</c> if the endpoint targets an | ||
| /// exchange or a queue that is not part of the transport topology. | ||
| /// Gets the target queue for this endpoint, or <c>null</c> if the endpoint targets an exchange. | ||
| /// </summary> | ||
| public RabbitMQQueue? Queue { get; private set; } |
Comment on lines
+172
to
+174
| Exchange = | ||
| topology.Exchanges.FirstOrDefault(e => e.Name == configuration.ExchangeName) | ||
| ?? throw new InvalidOperationException("Exchange not found"); |
Contributor
Patch coverage93.9% of changed lines covered (92/98)
Uncovered changed lines (JSON){
"sha": "337771ab103afa0d6771ba51e73bae61c0918227",
"files": [
{ "path": "src/Mocha/src/Mocha.Transport.RabbitMQ/RabbitMQMessagingTransport.cs", "ranges": [[295, 296]] },
{ "path": "src/Mocha/src/Mocha.Transport.RabbitMQ/Topology/RabbitMQRoutingStrategy.cs", "ranges": [[595, 596], [619, 620]] }
]
}Project coverage: 58.5% (313812/536093 lines) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with GitHub Stacks CLI • Give Feedback 💬