Skip to content

Pin dtolnay/rust-toolchain to master instead of stable - #10476

Merged
glen-84 merged 1 commit into
mainfrom
gai/pin-rust-toolchain-to-master
Oct 4, 2026
Merged

glen-84 merged 1 commit into
mainfrom
gai/pin-rust-toolchain-to-master

Conversation

@glen-84

@glen-84 glen-84 commented Oct 4, 2026

Copy link
Copy Markdown
Member

Summary

  • dtolnay/rust-toolchain publishes from master. Each toolchain branch (stable, beta, nightly, and one per Rust version) is a single commit on top of master that sets the default toolchain input, and is rebuilt whenever master moves. A pin taken from stable therefore soon belongs to no branch, and no newer version can be worked out from it.
  • Both Rust steps in cost-oracle-nightly.yml now pin a master commit. Both steps already pass toolchain: stable, so they still install stable Rust.
  • The new pin adds --force-non-host to the action's rustup toolchain install and rustup default calls. Nothing else in action.yml changes.

Test plan

  • Confirmed with the GitHub compare API that the pinned commit is on master (behind).
  • Reviewed the upstream diff from the previous pin's base to the new pin: action.yml changes by the two --force-non-host flags, plus a new job in the action's own CI.
  • This workflow runs only on its schedule and on workflow_dispatch, so this PR's CI does not exercise it. The first nightly run after merge does, or a manual dispatch on this branch.

Copilot AI lite review requested due to automatic review settings October 4, 2026 08:41

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot review overview

🟢 Approval recommended

The reviewed workflow changes are focused and have no unresolved blocking issues.

Review effort: Lite
Findings: None

What changed in this PR

Updates the nightly cost-oracle workflow to pin dtolnay/rust-toolchain to a commit on master while continuing to install stable Rust.

Changes:

  • Updated both Rust toolchain action pins.
  • Preserved toolchain: stable in both jobs.
File Description
.github/​workflows/​cost-oracle-nightly.yml Updates both Rust installation steps to the new upstream commit.

💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.

@glen-84
glen-84 merged commit e8e1ece into main Oct 4, 2026
159 checks passed
@glen-84
glen-84 deleted the gai/pin-rust-toolchain-to-master branch October 4, 2026 09:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants