Repository navigation
Pin dtolnay/rust-toolchain to master instead of stable - #10476
Merged
Merged
Conversation
Contributor
There was a problem hiding this comment.
Copilot review overview
🟢 Approval recommended
The reviewed workflow changes are focused and have no unresolved blocking issues.
Review effort: Lite
Findings: None
What changed in this PR
Updates the nightly cost-oracle workflow to pin dtolnay/rust-toolchain to a commit on master while continuing to install stable Rust.
Changes:
- Updated both Rust toolchain action pins.
- Preserved
toolchain: stablein both jobs.
| File | Description |
|---|---|
.github/workflows/cost-oracle-nightly.yml |
Updates both Rust installation steps to the new upstream commit. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
dtolnay/rust-toolchainpublishes frommaster. Each toolchain branch (stable,beta,nightly, and one per Rust version) is a single commit on top ofmasterthat sets the defaulttoolchaininput, and is rebuilt whenevermastermoves. A pin taken fromstabletherefore soon belongs to no branch, and no newer version can be worked out from it.cost-oracle-nightly.ymlnow pin amastercommit. Both steps already passtoolchain: stable, so they still install stable Rust.--force-non-hostto the action'srustup toolchain installandrustup defaultcalls. Nothing else inaction.ymlchanges.Test plan
master(behind).action.ymlchanges by the two--force-non-hostflags, plus a new job in the action's own CI.workflow_dispatch, so this PR's CI does not exercise it. The first nightly run after merge does, or a manual dispatch on this branch.