Skip to content

test(web): settle the lazy Guidance tab inside act() in SettingsModal guidance test #176

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ChesterRa merged 2 commits into from
Oct 23, 2026
Merged

test(web): settle the lazy Guidance tab inside act() in SettingsModal guidance test #176

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
84cd70c
test(web): settle the lazy Guidance tab inside act() in SettingsModal…
chriscoveries Oct 22, 2026
de39135
test(web): bound Guidance readiness before the test timeout
chriscoveries Oct 22, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion web/src/components/SettingsModal.guidance.test.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,16 @@ it.each([0, 1])(
/>,
),
);
await vi.waitFor(() => expect(host.querySelectorAll("textarea")).toHaveLength(2));
// GuidanceTab is a lazy chunk. Wait for it inside act() so its retry render, its
// prompt load and their effects are flushed by act(), not by the Scheduler after the
// test has moved on. act() flushes only when its outermost scope exits, so poll
// between back-to-back scopes rather than with vi.waitFor inside one.
// Bounded under the 5 s test timeout so a lazy-chunk failure ends at this assertion.
const readinessDeadline = Date.now() + 4000;
while (host.querySelectorAll("textarea").length < 2 && Date.now() < readinessDeadline) {
await act(async () => new Promise((resolve) => setTimeout(resolve, 10)));
}
expect(host.querySelectorAll("textarea")).toHaveLength(2);
const trigger = [...host.querySelectorAll<HTMLButtonElement>("button")].filter(
(button) => button.textContent === "guidance.expand",
)[index];
Expand Down
Loading