Skip to content

ci(preview-build): select latest preview branch#15424

Open
kangfenmao wants to merge 1 commit into
mainfrom
ci/v2-preview-build
Open

ci(preview-build): select latest preview branch#15424
kangfenmao wants to merge 1 commit into
mainfrom
ci/v2-preview-build

Conversation

@kangfenmao
Copy link
Copy Markdown
Collaborator

What this PR does

Before this PR:
The v2 daily preview build always checked out the hard-coded v2 branch and patched preview app identity values before building.

After this PR:
The workflow discovers the latest preview/v* branch by semantic version, builds that exact commit, patches package.json with the selected preview version before packaging, and only patches the preview product name.

Fixes #N/A

Why we need it and why it was done in this way

The following tradeoffs were made:
The branch/version resolution is implemented directly in the workflow so the metadata job can run before dependencies are installed and all platform builds can reuse the same selected commit.

The following alternatives were considered:
Using a fixed v2 branch was kept out because preview artifacts need to follow the newest preview release branch. Installing project dependencies just to use a semver helper was avoided to keep metadata resolution lightweight.

Links to places where the discussion took place: N/A

Breaking changes

None.

If this PR introduces breaking changes, please describe the changes and the impact on users.

Special notes for your reviewer

This only changes the preview build workflow. It does not change committed package.json or electron-builder.yml; those files are patched in the CI workspace before packaging.

Checklist

This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.

Release note

NONE

@kangfenmao kangfenmao requested a review from a team May 29, 2026 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants