ci(preview-build): select latest preview branch#15424
Open
kangfenmao wants to merge 1 commit into
Open
Conversation
…nd version handling
0xfullex
approved these changes
May 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Before this PR:
The v2 daily preview build always checked out the hard-coded
v2branch and patched preview app identity values before building.After this PR:
The workflow discovers the latest
preview/v*branch by semantic version, builds that exact commit, patchespackage.jsonwith the selected preview version before packaging, and only patches the preview product name.Fixes #N/A
Why we need it and why it was done in this way
The following tradeoffs were made:
The branch/version resolution is implemented directly in the workflow so the metadata job can run before dependencies are installed and all platform builds can reuse the same selected commit.
The following alternatives were considered:
Using a fixed
v2branch was kept out because preview artifacts need to follow the newest preview release branch. Installing project dependencies just to use a semver helper was avoided to keep metadata resolution lightweight.Links to places where the discussion took place: N/A
Breaking changes
None.
If this PR introduces breaking changes, please describe the changes and the impact on users.
Special notes for your reviewer
This only changes the preview build workflow. It does not change committed
package.jsonorelectron-builder.yml; those files are patched in the CI workspace before packaging.Checklist
This checklist is not enforcing, but it's a reminder of items that could be relevant to every PR.
Approvers are expected to review this list.
/gh-pr-review,gh pr diff, or GitHub UI) before requesting review from othersRelease note