Repository navigation
test: validate compiler against official WebAssembly core suite - #63
Merged
Merged
Conversation
Visual recap — skippedThe visual recap job did not run for this pull request. This is informational only and does not block the PR. Recap skipped for |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Linked issue
Closes #51
Observable behavior
The existing compiler-contracts workflow now runs a bounded official WebAssembly core-suite fixture through WAST parsing, wasm encoding, decode, translation, and the pinned Luau runtime. It reports passed, failed, and skipped-by-scope assertions separately; the current compiler reports 17 passed, 4 failed, and 0 skipped because its generated
div_shelper does not model the four official divide-by-zero and signed-overflow traps. Those trap assertions fail rather than being counted as passes.Proof
cargo fmt --all -- --checkcargo clippy --all-targets --all-features --locked -- -D warningscargo test --all-targets --locked -- --skip given_official_i32_core_assertions_when_run_through_luau_then_they_passcargo test --test wasm_spec --locked -- --nocaptureproduces the intended regression signal:passed=17, failed=4, skipped-by-scope=0.tests/fixtures/wasm-spec/core/README.md.