fix: improve lookback tipset check error message#7327
Conversation
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Run ID: 📒 Files selected for processing (2)
🔗 Linked repositories identifiedCodeRabbit considers these linked repositories for cross-repo context during reviews:
WalkthroughThis PR modifies ChangesLookback overflow error handling
Estimated code review effort: 3 (Moderate) | ~20 minutes Possibly related PRs
Suggested reviewers: 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
✨ Simplify code
Warning Review ran into problems🔥 ProblemsLinked repositories: Couldn't analyze Comment |
Codecov Report❌ Patch coverage is
Additional details and impacted files
... and 10 files with indirect coverage changes Continue to review full report in Codecov by Harness.
🚀 New features to boost your workflow:
|
|
|
||
| // More null blocks than lookback | ||
| // More null blocks than our lookback | ||
| if lbr >= heaviest_tipset.epoch() { |
There was a problem hiding this comment.
@hanabi1224 I think adding a small unit test for this change will be helpful
nit: You can use the guard-first shape here, but that just my personal preference, you can leave or take it.
Summary of changes
Ports the error message improvement from https://github.com/filecoin-project/lotus/pull/13680/changes#diff-b62548166087e88f8ca2c5613b67b4a44fc090cf65311824d3efbcd1e87182c9R185
Changes introduced in this pull request:
Reference issue to close (if applicable)
Closes
Other information and links
Change checklist
Outside contributions
Summary by CodeRabbit