Skip to content

Fix use-rewards fetchAll not setting error state #555

Closed

Description

@DeFiVC

What

use-rewards.ts fetchAll catches errors but only console.errors them. The error state is never set, so the UI has no way to show balance/history fetch failures.

Why

Users see a loading state that resolves to empty data with no error indication.

Scope

  • Set setError(...) in the fetchAll catch block
  • Ensure the error is cleared on successful fetch

Acceptance Criteria

  • Balance/history fetch errors are exposed via the error state
  • Error is cleared on subsequent successful fetch
  • npm test passes

Technical Context

  • File: src/lib/hooks/use-rewards.ts (around line 102)

Activity

  1. added
    bugSomething isn't working
    mediumFunctionality impaired but workaround exists, edge case, partial feature
    on Oct 14, 2026
  2. oomokaro1 commented on Oct 22, 2026

    @oomokaro1
    Contributor

    @oomokaro1 has applied to work on this issue as part of the Stellar Wave Program's 10th wave.

    I would love to work on this issue.

    ℹ️ Repo Maintainers: To accept this application, review their application or assign @oomokaro1 to this issue.

  3. drips-wave commented on Oct 22, 2026

    @drips-wave

    Congratulations, @oomokaro1! 🎉 Your application was accepted by the repo's maintainers, and the issue is due on October 22, 2026.

    🧑‍💻 @oomokaro1: Please resolve the issue such that the repo's maintainers have enough time to review your contribution before the due date. You'll earn Points for completing the issue on-time, which will make you eligible for a share of the Stellar Wave Program's reward pool.

    Warning

    When opening a PR, please link it to this issue to ensure it gets tracked accurately. Points are awarded when this issue is marked as completed by the maintainer.

    🤠 Repo maintainers: Please keep an eye on the contributor's progress and review their work before the due date. You can manage this issue, including adjusting its complexity and points, here.

    🌊 Happy Wave 🌊

  4. grantfox-oss commented on Oct 23, 2026

    @grantfox-oss

    🎉 This issue has been marked as completed on GrantFox!

    @oomokaro1's PR #668 was approved and merged by @DeFiVC.

    🏆 @oomokaro1: You earned 40 FoxPoints for this contribution! Your current tier: Builder (1,062 total points). Track your full progress on GrantFox.

    👏 Great work, @oomokaro1! Keep contributing to ChainLearnOfficial.

  5. drips-wave commented on Oct 23, 2026

    @drips-wave

    This issue has been completed by @oomokaro1 as part of the Stellar Wave Program's 10th Wave 🥳

    😎 @oomokaro1: You earned 200 Points for completing this issue! Once the Wave's rewards are finalized, you'll be eligible for a percentage of the Wave's reward pool based on the percentage of total points you've earned. Learn more here. You can also Leave a review to share your experience working on this issue.

    🧑‍💻 Repo maintainers: How'd the contributor do? Leave a review to share your experience working with them.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

Labels

Stellar WaveIssues in the Stellar wave programbugSomething isn't workingmediumFunctionality impaired but workaround exists, edge case, partial featuretypescriptTypeScript language

Type

No type

Projects

No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions