Conversation
Summary
Errors per inputErrors in ./references/providers/providers.csv
Timeouts per inputTimeouts in ./references/providers/providers.csv
|
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: REQUEST_CHANGES
Risk: MEDIUM
Summary: The CSV structure is stable and the PR only fills previously blank provider cells, but two newly added provider URLs are not usable. The current-cycle link-check run 33096311408 completed with workflow success while reporting URL failures in references/providers/providers.csv, and manual checks confirmed these two PR-introduced failures.
Findings:
- MEDIUM
references/providers/providers.csv:298(ghostgraph): the newwebsitevaluehttps://tryghost.xyz/graphreturns HTTP 404. Please replace it with a working official GhostGraph/Ghost URL or leave the field blank if there is no stable public page. - MEDIUM
references/providers/providers.csv:559(solar-wallet): the newdocsvaluehttps://docs.solarwallet.io/returns HTTP 503. Please use a reachable official docs/support URL or leave the field blank until it is available.
Confidence: HIGH
9eafd00 to
709027b
Compare
|
Both URLs are fixed in 1e165ee.
The commit touches two cells and nothing else: 720 rows, all 14 columns, verified by parsing the file rather than by line offset. |
Summary
Errors per inputErrors in ./references/providers/providers.csv
Timeouts per inputTimeouts in ./references/providers/providers.csv
|
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: COMMENT
Risk: LOW
Summary: The two URL issues from the previous review are addressed: ghostgraph now uses https://tryghost.xyz/, and the unreachable Solar Wallet docs value is no longer introduced by this PR. The CSV still parses with stable 14-column rows, the change only fills previously blank provider cells, and required validation is passing. I am not approving this cycle because the current reviewer-owned link-check report is not clean: run 33264495749 completed with workflow success but reported 1348 successful links, 10 URL errors, and 1 timeout in references/providers/providers.csv.
Findings: None.
Confidence: HIGH
|
Both URLs are fixed in 1e165ee.
The commit touches two cells and nothing else: 720 rows, all 14 columns, verified by parsing the file rather than by line offset. |
|
On the link-check run that posted after my last comment: none of the 10 errors are introduced by this PR. Eight of them are x.com URLs that do not appear in the diff at all — untouched rows — and six of those eight report "Connection failed" or "HTTP/2 protocol error", which is X blocking the checker rather than a dead link. The other three (developers.swing.xyz, swing.xyz, cloud.chainup.com) appear on both the removed and the added side of the diff: the row was modified for other cells, but those URLs were already there. The two failures the review did attribute to this PR — tryghost.xyz/graph and docs.solarwallet.io — are no longer in the list. |
|
@EazyHood this PR has been idle for more than 3 days, and the current blocker is unresolved requested changes. Please address the review feedback and update the PR when ready. |
|
Merged current upstream The old requested-changes review refers to URLs already fixed on the previous head. My fork permissions do not allow me to add the |
|
Hi @eugene17kotov - following up on this stale PR. Required CI is passing and I do not see a current creator-side blocker, so it looks ready for reviewer action when you have a chance. |
Rebuilt against current main from five of my own PRs that have been sitting in conflict: Chain-Love#2635, Chain-Love#2636, Chain-Love#2637, Chain-Love#2638 and Chain-Love#2993. providers.csv has taken 70 commits since 11 August, so rebasing them one at a time just puts them back in conflict a day later - and merging any one of them re-conflicts the rest, since all five edit the same file. This applies every cell from those five that is still empty on main today, and nothing else: supportEmail 164 docs 39 discord 108 github 10 x 65 website 9 telegram 60 linkedin 8 463 cells across 317 provider rows. No existing value is overwritten - the script only fills cells that are blank on main, and the five PRs proposed no conflicting values between them (zero disagreements across all 463). Verified row by row after the edit: 720 rows before and after, every changed row keeps its slug, and no changed cell had a prior value. validate_csv.py, csv_to_json.py and validate.py all pass. If this lands, Chain-Love#2635, Chain-Love#2636, Chain-Love#2637, Chain-Love#2638 and Chain-Love#2993 can be closed as superseded.
- ghostgraph website: https://tryghost.xyz/graph returns 404. Replaced with https://tryghost.xyz/, the studio's own site (200), which is the official page for the product. - solar-wallet docs: https://docs.solarwallet.io/ returns 503. Left blank, as the review offered, because no reachable official docs URL exists today: solarwallet.io/faq and /support are both 404 and help.solarwallet.io does not resolve. Both re-verified on 29 Aug. No other cell touched: 720 rows, all 14 columns.
5e0b948 to
df60efb
Compare
|
@eugene17kotov — a small mechanical request rather than a review one, if you have a moment. Thirteen of my open PRs are waiting on something I cannot trigger from a fork: the So these are not waiting on anyone's judgement. They are waiting on a run that only a label can start, and without the approval they never reach your queue at all. Blocked on a current-cycle link-check — Previously approved, dismissed when a commit landed, and not re-reviewed since — All thirteen are rebased on current Five others — If applying the label to a batch is awkward, tell me which order you would rather have them in and I will close the rest and re-open them a few at a time. I would rather fit your process than add thirteen rows to it. |
These rows carry the same values as main and only differed in CSV quoting, which put them in the diff and in the link check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
swing.xyz serves an invalid certificate and developers.swing.xyz does not resolve; www.mosaia.io serves an invalid certificate; learnweb3.io returns 503 Service Suspended; github.com/strangelove-ventures is gone (the org is now amygdala-labs, fixed in Chain-Love#3325). Touching those rows puts their dead links in the link check, so this PR leaves them as they are in main. The bybit x value pointed at the EU entity rather than the global exchange, so it is dropped too. The rows this PR does edit now keep main's quoting in their unchanged cells, so the diff shows only the cells it fills. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Chain-Love#3326 fills the same Temple Wallet x and discord cells and clears its dead docs link; editing the row here too would only put docs.templewallet.com, which times out, back into this PR's link check. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
Updated in |
|
@USS-Supervisor the findings from your 27 Aug review are addressed: |
main changed the sardine, vestige and xrpscan rows (Chain-Love#2817, Chain-Love#3922, Chain-Love#2818). This branch does not touch those rows, so they are taken from main as they are. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Summary
Errors per inputErrors in ./references/providers/providers.csv
|
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: REQUEST_CHANGES
Risk: HIGH
Summary: The prior GhostGraph and Solar Wallet findings are fixed, the 386 current changes preserve provider-field formatting, and required validation passed. Fresh link-check run 36206694353 reported one HTTP 304 on the unchanged Trust Wallet website; a direct recheck returned 200, so that is not treated as a PR defect. The blocking issue is extensive exact overlap with other active contributions.
Findings:
- HIGH —
references/providers/providers.csv: 166 of the 386 submitted cells exactly duplicate values in 24 still-open PRs. The largest repeated sets include 43 occurrences in #3914, 41 in #2977, 31 in #3326, 30 in #2890, 17 in #3324, and 11 each in #3323 and #3325; additional matches remain in #2859, #2864, #2880, #2884, #3333, #3554-#3556, #3685, #3720, #3721, #3913, #3964-#3966, #3982, and #3983. Please coordinate a single surviving contribution for each exact cell and remove the duplicates before re-review. The census excluded same-row/different-field edits and values already present on currentmain.
Confidence: HIGH
76 cells are proposed with the same value by PRs opened before this one (Chain-Love#2977, Chain-Love#2890, Chain-Love#2880, Chain-Love#2859, Chain-Love#2884, Chain-Love#2864). 46 are also in my own smaller batches Chain-Love#3323-Chain-Love#3326 and stay there only. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
17 of them are in Chain-Love#2977 (16 Aug), one in Chain-Love#2859 and one in Chain-Love#2880 (13 Aug), all opened before this PR with exactly the same values. The 31 cells shared with Chain-Love#3250 stay here: Chain-Love#3250 drops them instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Summary
Errors per inputErrors in ./references/providers/providers.csv
|
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: REQUEST_CHANGES
Risk: HIGH
Summary: The exact-overlap blocker is resolved for this earlier contribution, required validation passed, and the fresh link check's sole 304 is on unchanged trust.website. Current first-party evidence still exposes three provider-metadata issues that green CI cannot detect.
Findings:
- HIGH —
references/providers/providers.csv:546,secondfi.x=secondfiapp: SecondFi's current official site and knowledge base state that it is ceasing operations and will not resume normal operations. Remove this enrichment and coordinate a provider → offer → listing retirement audit instead. - MEDIUM —
references/providers/providers.csv:359,laevitas.docs=https://app.laevitas.ch/: this is the authenticated analytics dashboard, not documentation. Laevitas publishes its API documentation athttps://docs.laevitas.ch/; use that current docs URL or leave the field blank. - MEDIUM —
references/providers/providers.csv:332,infstones.discord=5Sgu93crrA: the current InfStones homepage publishesdiscord.gg/infstones, which resolves to a different current guild (InfStones Global). Replace the older invite withinfstonesor provide current first-party evidence for retaining it.
Confidence: HIGH
From USS-Supervisor's re-review:
- secondfi.x: removed. SecondFi's own site states it will not resume
normal operations, so the enrichment is dropped.
- laevitas.docs: app.laevitas.ch (the authenticated dashboard) -> docs.laevitas.ch,
the actual API documentation ("Getting Started | Laevitas V1.0 API").
- infstones.discord: 5Sgu93crrA -> infstones, the vanity published on the
current InfStones homepage (guild "InfStones Global").
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
@USS-Supervisor addressed in
The PR is now 263 cells across 195 provider rows; the title and description say so. |
|
@USS-Supervisor a gentle reminder: the three findings from your 26 Sep review ( |
Summary
Errors per inputErrors in ./references/providers/providers.csv
|
USS-Supervisor
left a comment
There was a problem hiding this comment.
Verdict: APPROVE
Risk: LOW
Summary: The three prior provider-metadata blockers are resolved on the exact current head. InfStones now uses the Discord invite published by its homepage, Laevitas now points to its API documentation, and the discontinued SecondFi X enrichment is removed. Required validation passed, and fresh reviewer-owned link-check run 36335114628 completed successfully; its sole reported 304 is the unchanged Trust Wallet website and a direct request returned 200.
Findings: None.
Confidence: HIGH
Summary
Rebuilt against current main from five of my own PRs that have been sitting in conflict: #2635,
#2636, #2637, #2638 and #2993.
providers.csvhas taken 70 commits since 11 August, so rebasing them one at a time only putsthem back in conflict a couple of days later - and merging any one of them re-conflicts the other
four, since all five edit the same file. Consolidating into one branch against today's main is the
only way out of that loop.
This applies the cells from those five that are still empty on main today and that no earlier open PR already proposes, and nothing else:
supportEmaildiscordtelegramdocsxgithubwebsitelinkedin263 cells across 195 provider rows today. When this was opened on 27 August it was 463 cells across
317 rows; Changes since it was opened below accounts for the difference.
No existing value is overwritten. The change only fills cells that are blank on main, and the
five PRs proposed no conflicting values between them - zero disagreements across the five.
Verified row by row after the edit: 727 rows before and after (re-checked on 26 Sep), every changed row keeps its slug,
and no changed cell had a prior value.
validate_csv.py,csv_to_json.pyandvalidate.pyallpass; the six
csv_to_jsonwarnings about camino, lightning and zilliqa are pre-existing andappear identically without this change.
If this lands, #2635, #2636, #2637, #2638 and #2993 can be closed as superseded. I will close them
myself once it is merged.
Changes since it was opened
Of the 463 cells in the first version, 200 are no longer in the diff:
64 were filled on
mainby other PRs in the meantime. In five of themmain's value differs from the one here (dappradartelegram,glifdocs,nownodesdiscord,nowpaymentsdocs,zerionlinkedin);main's is kept.2 went with rows deleted from
main(cid-checker,decubate-tms).1 dropped after the 27 Aug review:
solar-walletdocs (503). The same commit movedghostgraph's website tohttps://tryghost.xyz/.10 dropped on 24 Sep, because the link check reads whole rows and these rows carry links that fail today:
swing(swing.xyz serves an invalid certificate, developers.swing.xyz does not resolve),mosaia(www.mosaia.io serves an invalid certificate),learnweb3(503 "Service Suspended"),strangelove-ventures(github.com/strangelove-ventures is gone; the org is nowamygdala-labs, which data(providers): fill 23 missing link cells for 22 providers (batch 3 of 4) #3325 fixes) andtemple-wallet(docs.templewallet.com times out from six countries; data(providers): fill 25 missing link cells for 19 providers #3326 clears that link).bybit's x pointed at the EU entity,BybitEurope, rather than the global exchange, so it is dropped too.122 dropped on 26 Sep because other open PRs propose them. USS-Supervisor's census found 166 cells here that other open PRs also propose with the same value. 76 are in PRs opened before this one (data: fill 200 verified provider links (batch 1/3) #2977, data(providers): add verified contact emails #2890, data(providers): add verified official profiles #2880, Add verified provider social profiles #2884, data(security): fill missing provider links and offer fields for filecoin security listings #2859, data(oracles): fill verified offer + provider cells for Algorand/Filecoin/Somnia oracle listings #2864) and are removed. 46 are also in my own later batches data(providers): fill 32 missing link cells for 23 providers (batch 1 of 4) #3323-data(providers): fill 25 missing link cells for 19 providers #3326; they stay there and are removed here, so each lives in one of my PRs only. The remaining 44 are proposed only by PRs opened after this one (27 Aug): data(providers): add the X handle 16 providers publish on their own sites #3913 and data(providers): fill Discord and Telegram links 26 providers publish on their own sites #3914 (22 Sep), data(providers): add verified Saakuru community links #3964-data(providers): add verified FileDrive contact links #3966 (24 Sep), data(providers): add LinkedIn and GitHub links providers publish on their own sites #3982 and data(providers): add X, Telegram and Discord links providers publish on their own sites #3983 (25 Sep), data(providers): fill 13 verified documentation and social links for 10 Web3 providers (batch 2) #3554-data(providers): fill 10 verified social handles for prominent Web3 providers (batch 4) #3556 (2 Sep) and data(providers): add Wallet Verse contact details #3720 (8 Sep). By the rule used in data(sui): add Walrus decentralized storage #3687 and data(somnia): list the Pinata storage plans used by the Somnia NFT metadata guide #3854, where the later PR was the one to yield, this PR is the surviving contribution for those 44.
1 dropped on 26 Sep after re-review:
secondfi.x. SecondFi's own site states it will not resume normal operations, so the enrichment was removed. Two other flagged values were corrected in place, not dropped:laevitas.docsnow points at the API docs (docs.laevitas.ch) instead of the dashboard, andinfstones.discorduses the vanity published on the current homepage (infstones).Separately, 42 rows whose values this PR does not change differed from
mainonly in CSV quoting; they now keepmain's exact text, and the rows this PR does edit keepmain's quoting in their unchanged cells.Type of change
Scope
Networks affected: global (references/providers/providers.csv)
Categories affected: none - provider metadata only
Additional notes: edits were made line by line rather than by reserializing the CSV, so quoting
elsewhere in the file is untouched, and line endings are unchanged (the file stays LF throughout).
The diff is 195 insertions and 195 deletions - one line per touched provider row.
Links
Validation checklist
!providersyntax, and that entities in/networkssub-folders inherits records from/providersfolderOptional