new skill for serenity tests, adjusted skills for claude#287
Open
jasonmorais wants to merge 6 commits into
Open
new skill for serenity tests, adjusted skills for claude#287jasonmorais wants to merge 6 commits into
jasonmorais wants to merge 6 commits into
Conversation
…ing symlinks across the .claude and also fixing an old symlink
Contributor
Reviewer's GuideAdds a new Serenity/JS-focused File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
# Conflicts: # knip.json # pnpm-lock.yaml # pnpm-workspace.yaml
…ty-skill # Conflicts: # .agents/skills/README.md
# Conflicts: # packages/cellix/service-queue-storage/src/register-queues.ts
jasonmorais
changed the title
Contributor
Author
|
@sourcery-ai review |
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Hey - I've left some high level feedback:
Fixed security issues:
-
@opentelemetry/exporter-prometheus (link)
-
The
MockCommunityPermissions/MockUserPermissions(and related mock permission types) are now duplicated betweencreate.test.tsandupdate.test.ts; consider extracting these mocks into a shared test helper to avoid divergence and keep future changes to the permission surface in one place. -
Some newly changed statements (for example, the
onSavehandler inacceptance-uiand the long boolean condition inwaitForCommunityCreationQueueMessage) were compressed onto a single line, which makes them harder to read and review; consider reverting these to multi-line formatting for clarity.
Prompt for AI Agents
Please address the comments from this code review:
## Overall Comments
- The `MockCommunityPermissions` / `MockUserPermissions` (and related mock permission types) are now duplicated between `create.test.ts` and `update.test.ts`; consider extracting these mocks into a shared test helper to avoid divergence and keep future changes to the permission surface in one place.
- Some newly changed statements (for example, the `onSave` handler in `acceptance-ui` and the long boolean condition in `waitForCommunityCreationQueueMessage`) were compressed onto a single line, which makes them harder to read and review; consider reverting these to multi-line formatting for clarity.Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
nnoce14
approved these changes
Jul 6, 2026
gidich
approved these changes
Jul 7, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…ing symlinks across the .claude and also fixing an old symlink
Summary by Sourcery
Add a new Serenity/JS verification skill and documentation, integrate skills with Claude via symlinks, and refine staff role permission handling and tests.
New Features:
Bug Fixes:
Enhancements:
Build:
Tests: