Jason/extract local dev package by jasonmorais · Pull Request #270 · CellixJs/cellixjs

jasonmorais · 2026-06-04T15:15:48Z

Summary by Sourcery

Introduce shared local-development helper packages and update apps to use them for worktree-aware dev workflows.

New Features:

Add @cellix/local-dev package providing generic workspace discovery, dotenv/JSON utilities, worktree-aware URL and port helpers, and dev runners for Vite, Docusaurus, Azure Functions, Node, and Azurite.
Add @ocom/local-dev-config package encapsulating OCOM-specific local URL and hostname policy plus API local-settings configuration.

Enhancements:

Refactor API, UI, docs, mock OAuth2, and MongoDB mock apps to use new TypeScript-based local-dev entrypoints instead of .mjs scripts and TSX, centralising worktree logic.
Update e2e test environment to derive Azure Functions local settings via shared helpers and ensure portless proxy is cleanly restarted with stricter host matching.
Expose additional types from service-queue-storage and tidy various import orders and formatting across the codebase.
Tighten pnpm overrides, Sonar coverage exclusions, and Azure Storage SDK version pinning to align with catalog settings.

Tests:

Add comprehensive unit tests for @cellix/local-dev and @ocom/local-dev-config packages, covering workspace resolution, dotenv parsing, URL/port helpers, Azurite runner behaviour, worktree transforms, and OCOM URL derivation.

…variable and building them into the url for our various portless hosted services

… settings modes, for e2e, so we have alternate between settings files

…ogic

…ss-worktrees # Conflicts: # .snyk # pnpm-lock.yaml # pnpm-workspace.yaml

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

…y consumers of cellix

…sdom to happydom, and overall some code cleanliness changes

…eeded, and allowed more flexability for passing in of servers, gives user control of what they need. ensured api doesnt break across worktrees

…ork-refactor

sourcery-ai

Sorry @jasonmorais, your pull request is larger than the review limit of 150000 diff characters

…al app specific settings

…igh finalize, and standaridzed server configs and made them object focused

…r' into jason/extract-local-dev-package # Conflicts: # packages/cellix/serenity-framework/src/servers/process-test-server.test.ts # packages/ocom-verification/e2e-tests/src/infrastructure.ts # packages/ocom-verification/e2e-tests/src/test-server-factories.ts

…al-dev-package Resolves conflicts from upstream's later API/blob-storage work and its own ProcessTestServer simplification (dropped isReusableExit/probe/extraEnv in favor of url:string + automatic worktree env injection from the local-dev runner, which supersedes the manual extraEnv wiring this branch had). Kept this branch's local-dev package extraction (CELLIX_WORKTREE toggle, .ts wrapper scripts) and picked up upstream's build/script and dependency updates (tsgo --noEmit step, turbo 2.9.18, grpc-js/snyk override cleanup). Regenerated pnpm-lock.yaml from the merged manifests rather than hand resolving its conflicts, and removed two pnpm catalog entries (tsx, @azure/storage-blob) that the merged dependency set left unused. Removed the now-dead scripts/local-dev/worktree-ports.mjs conflict since this branch already moved that logic into @cellix/local-dev and verification-shared. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

…e2e detection forwardChildExit unconditionally overwrote process.exitCode, masking an earlier non-zero failure when a wrapper script owns more than one child process. Extracted the azurite runner's setProcessExitCode guard into process/index.ts as a shared helper and reused it from both forwardChildExit and the azurite runner. isE2E was duplicated verbatim in vite/index.ts, azure-functions-local-settings.ts, and @ocom/local-dev-config's api-settings builder. Centralized it in a new env/index.ts module exported from @cellix/local-dev. Also documented WorktreeSettings' value-content URL scanning (vs. the key-based convertSettingsForWorktree) so consumers aren't surprised by a setting value that happens to contain an http(s)/mongodb URL getting rewritten. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

jasonmorais · 2026-06-23T19:00:14Z

@sourcery-ai review

sourcery-ai

Hey - I've left some high level feedback:

There are now two distinct worktree transformation paths (WorktreeSettings scanning all settings vs convertSettingsForWorktree acting only on named keys); consider tightening the naming and documentation and adding guidance on when each should be used to avoid future misuse and unexpected rewrites of free‑text values.
Magic numbers for port derivation and hashing (e.g. base ports 50000/10000 and the 49‑bucket/100‑step logic in getWorktreePortOffset and related helpers) are currently embedded in the implementation; it may be worth centralizing these into clearly named constants so future adjustments are safer and easier to reason about.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- There are now two distinct worktree transformation paths (`WorktreeSettings` scanning all settings vs `convertSettingsForWorktree` acting only on named keys); consider tightening the naming and documentation and adding guidance on when each should be used to avoid future misuse and unexpected rewrites of free‑text values.
- Magic numbers for port derivation and hashing (e.g. base ports 50000/10000 and the 49‑bucket/100‑step logic in `getWorktreePortOffset` and related helpers) are currently embedded in the implementation; it may be worth centralizing these into clearly named constants so future adjustments are safer and easier to reason about.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

…ev-package # Conflicts: # pnpm-lock.yaml # pnpm-workspace.yaml

jasonmorais · 2026-06-30T19:05:21Z

@sourcery-ai review

sourcery-ai

Hey - I've reviewed your changes and they look great!

Fixed security issues:

@opentelemetry/exporter-prometheus (link)
@vitest/browser (link)
axios (link)
react-router (link)
shell-quote (link)

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

jasonmorais · 2026-06-30T20:10:17Z

@sourcery-ai review

sourcery-ai

Hey - I've left some high level feedback:

Fixed security issues:

@opentelemetry/exporter-prometheus (link)
@vitest/browser (link)
axios (link)
react-router (link)
shell-quote (link)
In @cellix/local-dev/package.json, the exports list does not include the ./vite and ./process subpaths that are documented in the README, which will break those import examples; consider adding those subpath exports or adjusting the README.
WorktreeSettings.transformRecord currently rewrites any http(s):// or mongodb:// substring found in string values (including nested objects/arrays), which could unintentionally alter non-config text; you may want to constrain this to specific keys or make the behavior opt-in per-setting.

Prompt for AI Agents

Please address the comments from this code review:

## Overall Comments
- In @cellix/local-dev/package.json, the exports list does not include the `./vite` and `./process` subpaths that are documented in the README, which will break those import examples; consider adding those subpath exports or adjusting the README.
- WorktreeSettings.transformRecord currently rewrites any `http(s)://` or `mongodb://` substring found in string values (including nested objects/arrays), which could unintentionally alter non-config text; you may want to constrain this to specific keys or make the behavior opt-in per-setting.

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

…ing main.tmp

jasonmorais · 2026-07-01T14:18:07Z

@sourcery-ai

jasonmorais · 2026-07-01T14:18:52Z

@sourcery-ai review

sourcery-ai

Hey - I've reviewed your changes and they look great!

Fixed security issues:

@opentelemetry/exporter-prometheus (link)
@vitest/browser (link)
axios (link)
react-router (link)
shell-quote (link)

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

gidich · 2026-07-01T16:12:44Z

@soucery-ai summarize

jasonmorais · 2026-07-01T19:09:03Z

@sourcery-ai summarize this prs changes

jasonmorais and others added 22 commits May 19, 2026 15:36

initial commit for verify

f78c3be

staging changes for portless modification - using worktree as an env …

09e9ab0

…variable and building them into the url for our various portless hosted services

fixes for e2e tests along with overall pattern cleanup

b4db123

overall improvements to workspace files, along with implementation of…

2d54c57

… settings modes, for e2e, so we have alternate between settings files

small fixes for build file issue

6c415ea

small improvements based on my comments, simplified overcomplicated l…

395bfcd

…ogic

Merge branch 'main' of github.com:CellixJs/cellixjs into jason/portle…

628694e

…ss-worktrees # Conflicts: # .snyk # pnpm-lock.yaml # pnpm-workspace.yaml

Merge remote-tracking branch 'origin/main' into jason/portless-worktrees

372b674

retrigger build

1522602

sourcery suggestions pt1

843f3d0

sourcery suggestions reound 2 - reusability

c184d92

Update readme.md

fabfb36

Co-authored-by: sourcery-ai[bot] <58596630+sourcery-ai[bot]@users.noreply.github.com>

undo tsc to tsgo

0b76477

fix serenity pattern - use task pattern instead of interaction

110f771

initial commit for verify

ba94849

modularize serenity framework in a way that can be more easily used b…

9be2b2d

…y consumers of cellix

reviewed changes on local with opus 4.8, made some adjustments from j…

865a5c3

…sdom to happydom, and overall some code cleanliness changes

made changes regarding infrastructure patterns, simplified what was n…

c0ab794

…eeded, and allowed more flexability for passing in of servers, gives user control of what they need. ensured api doesnt break across worktrees

Merge remote-tracking branch 'origin/main' into jason/serenity-framew…

de71fea

…ork-refactor

small refactor for test server pattern in api

a44fbe9

small adjustments based on codex review

0c1ae41

initial commit for verify

efa9134

sourcery-ai Bot reviewed Jun 4, 2026

View reviewed changes

jasonmorais changed the base branch from main to jason/serenity-framework-refactor June 4, 2026 15:16

jasonmorais added 6 commits June 4, 2026 11:44

initial script extraction - wip

dfdfb15

progress - cleaned up cellix package and created ocom package for loc…

0f53ffc

…al app specific settings

made some improvements to patterns for server startup based on api, w…

84b7285

…igh finalize, and standaridzed server configs and made them object focused

some adjustments to package pattern

b3d9969

Merge remote-tracking branch 'origin/main' into jason/portless-worktrees

b5840ea

jasonmorais and others added 2 commits June 23, 2026 14:20

sourcery-ai Bot reviewed Jun 23, 2026

View reviewed changes

Base automatically changed from jason/serenity-framework-refactor to main June 24, 2026 14:05

jasonmorais requested a review from a team June 24, 2026 14:05

fix merge conflicts

8a435b1

github-advanced-security AI found potential problems Jun 24, 2026

View reviewed changes

Comment thread packages/cellix/local-dev/src/urls/index.ts Fixed

jasonmorais added 2 commits June 24, 2026 13:25

small fixes

4b2dcfd

security fix

a9f581c

github-advanced-security AI found potential problems Jun 24, 2026

View reviewed changes

Comment thread packages/cellix/local-dev/src/urls/index.ts Fixed

jasonmorais added 6 commits June 24, 2026 13:54

second attempt for security fix

ad4a95a

small adjustments based on gpt 5.5 internal review, fix import

cbd2a9d

resolve merge conflicts

c53e669

removal of redudant flag for worktree in worktree command

dd56e31

Merge remote-tracking branch 'origin/main' into jason/extract-local-d…

a20138e

…ev-package # Conflicts: # pnpm-lock.yaml # pnpm-workspace.yaml

fix vulnerability

0dd81fc

nnoce14 previously approved these changes Jun 30, 2026

View reviewed changes

sourcery-ai Bot reviewed Jun 30, 2026

View reviewed changes

small sourcery feedback adjustment, and small fix for storybook creat…

232c87b

…ing main.tmp

jasonmorais dismissed nnoce14’s stale review via 232c87b July 1, 2026 13:55

sourcery-ai Bot reviewed Jul 1, 2026

View reviewed changes

gidich approved these changes Jul 7, 2026

View reviewed changes

Uh oh!

Conversation

jasonmorais commented Jun 4, 2026 • edited by sourcery-ai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Summary by Sourcery

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

jasonmorais commented Jun 23, 2026

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

jasonmorais commented Jun 30, 2026

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

jasonmorais commented Jun 30, 2026

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

jasonmorais commented Jul 1, 2026

Uh oh!

jasonmorais commented Jul 1, 2026

Uh oh!

sourcery-ai Bot left a comment

Choose a reason for hiding this comment

Uh oh!

gidich commented Jul 1, 2026

Uh oh!

jasonmorais commented Jul 1, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

jasonmorais commented Jun 4, 2026 •

edited by sourcery-ai Bot

Loading