Teamwork properties#10993
Open
tehdiplomat wants to merge 5 commits into
Open
Conversation
Contributor
|
@tehdiplomat why do you make a new Instance, than use the function instead of using a static function like before? |
Contributor
Author
|
I hate all of our places that are just Static functions. It feels so sloppy. |
Contributor
But that just creates new objects without good reason 🤔 @tool4ever your opinion on static vs non static? |
Contributor
|
yea spawning lots of new objects on each valid check doesn't feel right either maybe just convert them into Interfaces? then each Entity class can access its property check as a real instance method |
Hanmac
approved these changes
Jun 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.