Enforce automated tests before merge - #563
Closed
tosfos wants to merge 1 commit into
Closed
Conversation
tosfos
force-pushed
the
enforce-tests-before-merge
branch
from
December 18, 2025 23:52
9c9bfa9 to
1e3fd04
Compare
Member
|
@tosfos - this feels AI-generated, although still potentially useful. But would it be better to move some/all of this stuff to CanastaBase? Canasta PRs usually involve nothing more than updating an extension or skin. |
tosfos
marked this pull request as draft
December 19, 2025 00:19
Collaborator
Author
|
Yeah this is just an experiment of different ways to get testing into the repo. No plan to merge these. |
Collaborator
Author
|
Just doing CanastaWiki/CanastaBase#46 for now |
Member
|
Oh, okay. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Implement automated testing enforcement to ensure unit and integration tests pass before any merge to master. This prevents broken code from being deployed.
Changes Made
.github/workflows/docker-image.ymlto require e2e tests to pass before pushing Docker imagese2e/directory.github/PULL_REQUEST_TEMPLATE.mdto require test validation documentationcodecov.ymlfor test coverage reportingTesting Enforcement
The CI workflow now enforces that:
Test Coverage
Validation
How to verify this works:
Expected behavior: All future PRs must have passing tests before they can be merged.
Related Issues
Inspired by Taqasta's testing infrastructure. Ensures code quality and prevents regressions.
Closes testing enforcement requirements.