Skip to content

Enforce automated tests before merge - #563

Closed
tosfos wants to merge 1 commit into
masterfrom
enforce-tests-before-merge
Closed

Enforce automated tests before merge#563
tosfos wants to merge 1 commit into
masterfrom
enforce-tests-before-merge

Conversation

@tosfos

@tosfos tosfos commented Dec 18, 2025

Copy link
Copy Markdown
Collaborator

Description

Implement automated testing enforcement to ensure unit and integration tests pass before any merge to master. This prevents broken code from being deployed.

Changes Made

  • CI Workflow Enhancement: Modified .github/workflows/docker-image.yml to require e2e tests to pass before pushing Docker images
  • E2E Testing Infrastructure: Added Playwright-based end-to-end tests in e2e/ directory
  • PR Template Update: Enhanced .github/PULL_REQUEST_TEMPLATE.md to require test validation documentation
  • Code Coverage: Added codecov.yml for test coverage reporting

Testing Enforcement

The CI workflow now enforces that:

  1. E2E tests run automatically on all pull requests and pushes
  2. Docker images are only built and pushed if all tests pass
  3. Test failures prevent deployment of broken code

Test Coverage

  • E2E tests included (Playwright tests verify MediaWiki installation)
  • CI integration tests (workflow validation)
  • Manual testing completed (verified workflow structure)

Validation

How to verify this works:

  1. Create a PR with this branch
  2. CI will automatically run e2e tests
  3. If tests pass, Docker images will be built and pushed
  4. If tests fail, the workflow will fail and prevent merge

Expected behavior: All future PRs must have passing tests before they can be merged.

Related Issues

Inspired by Taqasta's testing infrastructure. Ensures code quality and prevents regressions.

Closes testing enforcement requirements.

@tosfos
tosfos force-pushed the enforce-tests-before-merge branch from 9c9bfa9 to 1e3fd04 Compare December 18, 2025 23:52
@yaronkoren

Copy link
Copy Markdown
Member

@tosfos - this feels AI-generated, although still potentially useful. But would it be better to move some/all of this stuff to CanastaBase? Canasta PRs usually involve nothing more than updating an extension or skin.

@tosfos
tosfos marked this pull request as draft December 19, 2025 00:19
@tosfos

tosfos commented Dec 19, 2025

Copy link
Copy Markdown
Collaborator Author

Yeah this is just an experiment of different ways to get testing into the repo. No plan to merge these.

@tosfos

tosfos commented Dec 19, 2025

Copy link
Copy Markdown
Collaborator Author

Just doing CanastaWiki/CanastaBase#46 for now

@tosfos tosfos closed this Dec 19, 2025
@yaronkoren

Copy link
Copy Markdown
Member

Oh, okay.

@tosfos
tosfos deleted the enforce-tests-before-merge branch December 23, 2025 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants