Repository navigation
fix(models): restore loading of saved models - #207
Merged
Merged
Conversation
Convert loaded model parameters to LIONModelParameter, stop its defaults overwriting passed-in values, and fall back to CPU when loading without CUDA. Adds save/load round-trip tests. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The code was written by AI, but I'm writing this PR message by hand.
Continuing the theme of some AI-assisted small bug fixes, Claude noticed that a recent PR (#188) broke the
load()function for models –load()usesLIONParameter, but that PR enforcesLIONModelParameter.This fixes the error, by making
load()useLIONModelParameterfor consistency, and adds some tests forload()andsave()to guard against future regression.