fix(vault): remove duplicate DuplicateRequestId variant and Settlemen…#409
Merged
greatest0fallt1me merged 1 commit intoJun 19, 2026
Merged
Conversation
…tClient The VaultError enum declared DuplicateRequestId = 29 twice and two traits both generated a SettlementClient, breaking compilation (E0428/E0081/E0592/ E0034/E0004). Collapse to a single definition each; error code stays 29. - Remove first DuplicateRequestId arm (wrong doc comment 'code 23') - Fix surviving arm doc to correctly state 'code 29' - Delete SettlementTrait block; only trait Settlement remains - Add docs/interfaces/vault.json error code 29 entry - Add test pinning DuplicateRequestId discriminant to 29
Contributor
|
nice, this is the right fix. collapsing the duplicate |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…tClient
The VaultError enum declared DuplicateRequestId = 29 twice and two traits both generated a SettlementClient, breaking compilation (E0428/E0081/E0592/ E0034/E0004). Collapse to a single definition each; error code stays 29.