Feedback - #1
Open
github-classroom[bot] wants to merge 144 commits into
Open
Conversation
1. Update readme for development 2. Create env file for the user service to setup local db 3. Create a doc to keep track of postman-api (further discussion if needed on documenting api) 4. Update user service logic to prevent duplicate account creation
feat(user): prevent duplicate account creation and set up repo
setup(feat): Setup typescript and eslint
fix(env): rename db
fix(user): convert to ts
setup(tailwind): frontend
Update matchPage with buttons and timer upon clicking Update pull request template
feat(match): Create difficulty buttons and timer
feat(user): handle user login in backend
There is no user login feature on the frontend. Let's create a user login feature that will store the user's login credentials in a cookie upon login to close #4
Update backend dependencies for login
feat(setup-socket): Setup socket io server and frontend for testing
feat(history): Implement frontend
Implement User Authentication for Question Service
feat(docker): Dockerize microservices except for frontend
Update history response interface
Beautify Login Page
Update confirm button
Fix bigbang export error
Fix error with EditorView typography
Update EditorView props
1. Update api docs and postman 2. Update authentication middleware for userservice
Update Big Bang
docs: Update documentations
Update login button colour
description overlay navbar fix the navbar overlay issue
Update historypage bug
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
👋! GitHub Classroom created this pull request as a place for your teacher to leave feedback on your work. It will update automatically. Don’t close or merge this pull request, unless you’re instructed to do so by your teacher.
In this pull request, your teacher can leave comments and feedback on your code. Click the Subscribe button to be notified if that happens.
Click the Files changed or Commits tab to see all of the changes pushed to
mainsince the assignment started. Your teacher can see this too.Notes for teachers
Use this PR to leave feedback. Here are some tips: - Click the **Files changed** tab to see all of the changes pushed to `main` since the assignment started. To leave comments on specific lines of code, put your cursor over a line of code and click the blue **+** (plus sign). To learn more about comments, read “[Commenting on a pull request](https://docs.github.com/en/github/collaborating-with-issues-and-pull-requests/commenting-on-a-pull-request)”. - Click the **Commits** tab to see the commits pushed to `main`. Click a commit to see specific changes. - If you turned on autograding, then click the **Checks** tab to see the results. - This page is an overview. It shows commits, line comments, and general comments. You can leave a general comment below. For more information about this pull request, read “[Leaving assignment feedback in GitHub](https://docs.github.com/education/manage-coursework-with-github-classroom/leave-feedback-with-pull-requests)”.Subscribed: @BrendonLau @pyk595 @EltonGohJH @justinyjt