Skip to content

ci: always use PR target branch as benchmark reference #2317

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sbrunato merged 1 commit into from
Aug 20, 2026
Merged

ci: always use PR target branch as benchmark reference #2317

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 6 additions & 5 deletions .github/workflows/benchmark.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@ name: Run benchmark

on:
pull_request:
branches: [develop, v5_download_link_asset]

permissions:
contents: read
Expand All @@ -26,15 +25,17 @@ jobs:
cache-dependency-glob: |
pyproject.toml
tox.ini
- name: Run benchmark on develop and current ref, then compare
- name: Run benchmark on target branch and current ref, then compare
shell: bash
env:
TARGET_BRANCH: ${{ github.event.pull_request.base.ref }}
run: |
set -euo pipefail

CURRENT_SHA="$(git rev-parse HEAD)"

echo "Running benchmark on develop"
git checkout --detach origin/develop
echo "Running benchmark on ${TARGET_BRANCH}"
git checkout --detach "origin/${TARGET_BRANCH}"
uvx --python 3.14 --with tox-uv tox -e benchmark -- --benchmark-json baseline.json

echo "Running benchmark on current ref"
Expand All @@ -51,7 +52,7 @@ jobs:
{
echo "## Benchmark comparison"
echo
echo "Compared baseline: \`origin/develop\`"
echo "Compared baseline: \`origin/${TARGET_BRANCH}\`"
echo "Compared candidate: ${CURRENT_SHA}"
echo
echo '```text'
Expand Down
Loading