Repository navigation
Play effects over a wallpaper in shiftpaper-render - #30
Merged
Merged
Conversation
OutputRenderState::start_effect plays a short effect over the wallpaper showing, starting from a point on the screen, for front ends to mark a moment like a phone unlocking. Each moves through the depth of the scene and leaves it exactly as it was: - ripple: waves spread from the point across the screen and back through the scene at once, so they reach near things before far ones beside them, moving and lighting the picture as they pass. - swell: a band rolls from the nearest things to the furthest by depth rank, each part of the scene leaning toward the viewer as it passes. - glint: a band of warm light passes back through the scene the same way, catching the brighter parts most. Effects show over a wallpaper at rest, not during a transition.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Tiltpane plays something as the phone unlocks. Its first go moved the camera (a small zoom, or a lift), which didn't use the depth and felt flat next to the transitions. This adds effects that move through the scene itself.
Effect(public):Ripple,SwellandGlint, withALLandas_str()likeTransitionOutputRenderState::start_effect(effect, duration, origin): plays one over the wallpaper showing, starting fromoriginin screen uv.is_playing_effect()says whether one is going, andstep_and_writereports a change while one plays, so it gets drawneffect,effect_progressandeffect_origin. With no effect the shader takes the same path as beforeshiftpaperd doesn't use any of this, so it looks the same.
Format, clippy and tests pass. New tests check the effect numbers match the shader, the names are unique, and the timing runs evenly to the end. Tiltpane builds against this branch, and on the emulator each effect plays on unlock as described. Not yet run on the Pixel or the desktop.