Repository navigation
Zoom in further for a stronger parallax - #28
Merged
Merged
Conversation
The margin the shader zooms in by was fixed at 2.5% each side, enough for an intensity of 0.05. It now grows to half the intensity when that's more, so stronger settings no longer pull in the stretched edge.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The shader zooms in 2.5% on each side, so shifted pixels come from beyond the screen instead of the stretched edge. That's enough for a
parallax_intensityup to 0.05. Past that, the biggest shifts reached the edge.start_transitionzooms the scale it hands the portal and dissolve by the same margin, from the intensitystep_and_writelast drew withNearfar wants a stronger parallax on phones (0.08), which is what this is for. Format, clippy and tests pass locally, with a new test that the margin covers the biggest shift, and the render crate still checks for Android. Not yet run on the desktop.