Repository navigation
Don't pass textures to functions in the shader - #27
Merged
Merged
Conversation
Mali's Vulkan driver segfaults compiling a texture passed to a function, so the helpers that read depth and ranks now pick the current or next wallpaper's texture themselves.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Mali's Vulkan driver segfaults while compiling the shader, which takes down whatever is drawing with it. The crash is in its SPIR-V compiler, tracing a texture passed to a function back to where it was declared.
load_depth,depth_rankandheight_ranknow take a flag for the current or next wallpaper and read that one's texture themselves, through a newload_ranksFound on a Pixel 9 Pro (Mali-G715, Android 17), where the fix draws correctly on Vulkan. Format, clippy and tests pass locally, and the render crate still checks for Android. Not yet run on the desktop.