Antenna panel changes - #62
Open
Landwhich wants to merge 5 commits into
Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates antenna-related UI behavior by changing how manual antenna control is published over ROS topics and by surfacing base-station antenna position/heading in the map breadcrumb/status overlay.
Changes:
- Antenna control now publishes to separate ROS topics for manual value (
/antenna/manual_value) and manual status (/antenna/manual), and adjusts manual step magnitude. - Breadcrumb/status overlay now subscribes to base-station fix and tracker bearing topics and displays antenna location + heading.
- Tightens spacing in the breadcrumb/status panel.
Reviewed changes
Copilot reviewed 1 out of 1 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/components/panels/AntennaControlPanel.tsx | Split antenna control publishing into value + status topics; adjust manual control step and UI enable/disable behavior. |
| src/components/BreadCrumbTrail.tsx | Subscribe to antenna fix/bearing topics and display antenna location/heading in the status overlay. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.