Fix logs disappearing when a container is stopped | ROVER-629 - #61
Open
jaydizz0 wants to merge 1 commit into
Open
Fix logs disappearing when a container is stopped | ROVER-629#61jaydizz0 wants to merge 1 commit into
jaydizz0 wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes ROVER-629 - logs were disappearing as soon as you hit stop, even though the container hadn't actually finished shutting down yet.
Turned out there were two things causing this:
option.statuschanged, not just when a new container actually started. So clicking stop triggered the same clear that was only supposed to happen for a new container:'stopped', no matter what was actually in it:Fixed by splitting that effect into three, so logs only get cleared when
option.idactually changes (a real new container), and changed the render check so the box stays up if there's still something inlogs.I don't have a real container-launcher running locally to test against, so I built a small throwaway test page + a fake websocket server to feed fake log lines into the real ContainerCard component and reproduce the bug directly. Confirmed logs used to vanish instantly on stop, and now they stick around after. Deleted both test files before this commit, so it's just the actual fix.