Repository navigation
Add HTTPS support and replace the legacy release workflow - #106
Merged
Merged
Conversation
Allow Vite and Nginx to serve the GUI over HTTPS while keeping backend certificate verification configurable for local self-signed certificates. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This was
linked to
issues
Sep 24, 2026
Closed
Paul2803k
changed the title
Paul2803k
force-pushed
the
feature/https-release
branch
from
September 24, 2026 12:19
8906e17 to
9c87f28
Compare
MaartendeKruijf
requested changes
Sep 24, 2026
| tags: cossas/soarca-gui:pr-${{ env.describe_version }} | ||
| build-args: | | ||
| VERSION=${{ env.describe_version }} | ||
| VITE_APP_VERSION=${{ env.describe_version }} |
Contributor
There was a problem hiding this comment.
Is there a reason to not use plain version?
Collaborator
Author
There was a problem hiding this comment.
we use it to later on inject it into the build of the app and it needs to start with VITE_ to be used.
| push: true | ||
| target: production | ||
| tags: | | ||
| cossas/soarca-gui:${{ github.ref_name }} |
Contributor
There was a problem hiding this comment.
This should be the describe version right? This is consistent over all Github and non Github describe.
Contributor
There was a problem hiding this comment.
Also it keeps it consistent with the CI build
Collaborator
Author
There was a problem hiding this comment.
ah yes, it should be the same tho no? as this is triggered by the pushed tag. But for consistency i will bring back the old thing
Contributor
There was a problem hiding this comment.
It should, but is not guaranteed if we change release process.
MaartendeKruijf
approved these changes
Sep 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds HTTPS support to SOARCA-GUI, replaces the Go-based release workflow, and includes the manual-action fixes from one of my old branches. It was not super necessary but let's keep it as a baseline.
In details for the HTTPS support, changes include: