Migrate public headers to include/sbgraph and enforce <sbgraph/...> consumption - #143
Conversation
Co-authored-by: Kalashnikovni <19693048+Kalashnikovni@users.noreply.github.com>
Co-authored-by: Kalashnikovni <19693048+Kalashnikovni@users.noreply.github.com>
include/sbgraph and enforce <sbgraph/...> consumption
There was a problem hiding this comment.
Build failed, corrections are needed. @copilot is mandatory that the project builds and passes tests.
Kalashnikovni
left a comment
There was a problem hiding this comment.
Build failed, corrections are needed. @copilot is mandatory that the project builds and passes tests.
Co-authored-by: Kalashnikovni <19693048+Kalashnikovni@users.noreply.github.com>
Addressed in commit |
Co-authored-by: Kalashnikovni <19693048+Kalashnikovni@users.noreply.github.com>
Kalashnikovni
left a comment
There was a problem hiding this comment.
@copilot Build still not complete, fails with the error:
[100%] Building CXX object test/performance/CMakeFiles/sbg-benchmark.dir/utils.cpp.o
/home/runner/work/sb-graph/sb-graph/test/performance/utils.cpp: In function ‘bool SBG::perf::detail::updateN(const std::string&, int)’:
/home/runner/work/sb-graph/sb-graph/test/performance/utils.cpp:65:11: error: ‘ERROR’ is not a member of ‘SBG::Util’
65 | Util::ERROR("Unable to open file ", filename, "\n");
| ^~~~~
make[2]: *** [test/performance/CMakeFiles/sbg-benchmark.dir/build.make:219: test/performance/CMakeFiles/sbg-benchmark.dir/utils.cpp.o] Error 1
make[1]: *** [CMakeFiles/Makefile2:1363: test/performance/CMakeFiles/sbg-benchmark.dir/all] Error 2
make: *** [Makefile:136: all] Error 2
Co-authored-by: Kalashnikovni <19693048+Kalashnikovni@users.noreply.github.com>
Fixed in commit |
bd2bb88
into
iss-135-define-include-directory
This PR migrates sb-graph’s public header surface to a namespaced include layout so downstream users consume headers via
<sbgraph/...>instead of ambiguous top-level paths. It also updates CMake export/install wiring soSBG::sbgraphexposes only the prefixed public include tree.Public API include layout
include/sbgraph/tree and placed the required public API headers underinclude/sbgraph/<original path>.Include-path migration across project sources
algorithms/...,eval/...,sbg/...,util/..., etc.) to<sbgraph/...>.CMake interface + install behavior
SBG::sbgraphnow uses:BUILD_INTERFACE: ${PROJECT_SOURCE_DIR}/includeINSTALL_INTERFACE: ${CMAKE_INSTALL_INCLUDEDIR}include/sbgraphto${CMAKE_INSTALL_INCLUDEDIR}.SBGraphConfig.cmake,SBGraphTargets.cmake,SBG::sbgraph).Consumer validation target
<sbgraph/...>and links throughSBG::sbgraph.make: *** No rule to make target 'test'. Stop.