Update icedrv_init.F90 to read in dynamics_nml - #568
Marek-Muchow wants to merge 1 commit into
Conversation
The dynamics_nml was defined, but not loaded from icepack_in. Thus, the variables in dynamics_nml were always set to the default parameters.
|
In standalone Icepack, there is no dynamics. That's probably why it's not read in. Are there namelist settings in dyn_nml that matter for standalone Icepack? |
eclare108213
left a comment
There was a problem hiding this comment.
Good catch. It would be helpful to have results from Icepack's base_suite, which includes tests with different values of the dynamics options. If I understand the problem correctly, some of the base_suite results will be non-BFB, indicative of the error. Instructions for running test suites can be found here. Let us know if you have questions or need other help with this. Thank you for finding and fixing the problem!
Icepack owns some dynamics-related things like ice strength, ridging, and surface stress calculations, even though it does not calculate internal stress / momentum / advection. |
PR checklist
This fixes loading the dynamics_nml, which was defined in icedrv_init.F90, but not loaded from icepack_in (in the stand-alone version).
I only tested it locally, results did not change as expected as only driver script for stand-alone case was adapted.
The dynamics_nml was defined, but not loaded from icepack_in (when using icepack in the stand alone version). Thus, the variables in dynamics_nml were always set to the default parameters and flexibility in the code (for example switching between the ice strength parametrisations (kstrength = 1 or 0) and ridging schemes (krdg_redist = 1 or 0) was not possible via icepack_in).
Problem was also mentioned in the Forum (https://bb.cgd.ucar.edu/cesm/threads/icepack-stand-alone-dynamics_nml-from-icepack_in-get-overwritten-by-default-parameters.12290/).