Skip to content

Update Carpenter port, fix missing NO_MPI CPP - #1131

Merged
apcraig merged 2 commits into
CICE-Consortium:mainfrom
apcraig:carp5
Aug 18, 2026
Merged

apcraig merged 2 commits into
CICE-Consortium:mainfrom
apcraig:carp5

Conversation

@apcraig

@apcraig apcraig commented Aug 18, 2026

Copy link
Copy Markdown
Contributor

PR checklist

  • Short (1 sentence) summary of your PR:
    Update Carpenter port, fix missing NO_MPI CPP
  • Developer(s):
    apcraig
  • Suggest PR reviewers from list in the column to the right.
  • Please copy the PR test results link or provide a summary of testing completed below.
    Some answers changes on Carpenter due to the port update, but otherwise, answers are bit-for-bit. https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#811daa9d666c6bcdae40f4917778574b042f70b4
  • How much do the PR code changes differ from the unmodified code?
    • bit for bit except Carpenter
    • different at roundoff level
    • more substantial
  • Does this PR create or have dependencies on Icepack or any other models?
    • Yes
    • No
  • Does this PR update the Icepack submodule? If so, the Icepack submodule must point to a hash on Icepack's main branch.
    • Yes
    • No
  • Does this PR add any new test cases?
    • Yes
    • No
  • Is the documentation being updated? ("Documentation" includes information on the wiki or in the .rst files from doc/source/, which are used to create the online technical docs at https://readthedocs.org/projects/cice-consortium-cice/. A test build of the technical docs will be performed as part of the PR testing.)
    • Yes
    • No, does the documentation need to be updated at a later time?
      • Yes
      • No
  • Please document the changes in detail, including why the changes are made. This will become part of the PR commit log.

Update Carpenter port, changes answers for some compilers.

Fix missing NO_MPI CPP in ice_communicate and ice_gather_scatter needed for serial builds around the "use mpi" code. This was caught by compilers on Carpenter and Izumi.

Fix missing NO_MPI CPP in ice_communicate and ice_gather_scatter needed for serial builds.  This was caught by compilers on Carpenter and Izumi.
@apcraig
apcraig merged commit 12181ec into CICE-Consortium:main Aug 18, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants