Skip to content

ci: Add gosec security test to workflow - #42

Open
CaioCordeiro wants to merge 3 commits into
CESARBR:masterfrom
CaioCordeiro:gosec_check
Open

ci: Add gosec security test to workflow#42
CaioCordeiro wants to merge 3 commits into
CESARBR:masterfrom
CaioCordeiro:gosec_check

Conversation

@CaioCordeiro

@CaioCordeiro CaioCordeiro commented Feb 1, 2021

Copy link
Copy Markdown

Describe what this PR introduces:

This patch adds a GO security check to GitHub Actions "Build and Test" workflow. This check is made using the gosec tool,
you can get more information visiting its repository: Gosec

What kind of change does this PR introduce? (check at least one)

  • Bug fix
  • Feature
  • Code style update
  • Refactor
  • Build-related changes
  • Other, please describe:

Does this PR introduce any breaking changes? (check one)

  • Yes
  • No

If yes, please describe the impact and migration path for existing applications:

In this repository code current state it will not pass the security test.

The PR fulfills these requirements:

  • Related issues are referenced in the PR (e.g. fix #xxx[,#xxx], where "xxx" is the issue number)
  • All tests are passing
  • New/updated tests are included

Testing environment:

  • Operating System/Platform:
  • Go version:

If you have relevant logs, error output and etc, please attach them.

Other information:

@lcbm lcbm left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Always nice to see security improvements around here! 🎉

Fix a security error where the fuction "Stop()" would end before the
AMQP channel could properly close.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants