Skip to content

Fix W computation causing PICCS to hang #784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
AnderBiguri merged 1 commit into from
Sep 29, 2026
Merged

Fix W computation causing PICCS to hang #784

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 1 addition & 8 deletions MATLAB/Algorithms/PICCS.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -85,14 +85,7 @@
% Projection weigth, W


geoaux=geo;
geoaux.sVoxel([1 2])=geo.sVoxel([1 2])*1.1; % a Bit bigger, to avoid numerical division by zero (small number)
geoaux.sVoxel(3)=max(geo.sDetector(2),geo.sVoxel(3)); % make sure lines are not cropped. One is for when image is bigger than detector and viceversa
geoaux.nVoxel=[2,2,2]'; % accurate enough?
geoaux.dVoxel=geoaux.sVoxel./geoaux.nVoxel;
W=Ax(ones(geoaux.nVoxel','single'),geoaux,angles,'Siddon','gpuids',gpuids); %
W(W<min(geo.dVoxel)/4)=Inf;
W=1./W;
W=computeW(geo,angles,gpuids);


% Back-Projection weigth, V
Expand Down
3 changes: 2 additions & 1 deletion Python/tigre/algorithms/iterative_recon_alg.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,7 @@ def set_w(self):
:return: None
"""
geox = copy.deepcopy(self.geo)
geox.sVoxel[1:] = geox.sVoxel[1:] * 1.1 # a bit larger to avoid zeros in projections
geox.sVoxel[1:] = geox.sDetector[1:] * 1.1 # a bit larger to avoid zeros in projections
geox.sVoxel[0] = max(geox.sDetector[0], geox.sVoxel[0])

geox.nVoxel = np.array([2, 2, 2])
Expand All @@ -250,6 +250,7 @@ def set_w(self):
)
W[W <= min(self.geo.dVoxel / 2)] = np.inf
W = 1.0 / W
W[W > 0.1] = 0.1
setattr(self, "W", W)

def set_v(self):
Expand Down
Loading