feat: Add Department links to Federal Sankey diagram spending items - #145
Open
ronakv wants to merge 2 commits into
Open
feat: Add Department links to Federal Sankey diagram spending items#145ronakv wants to merge 2 commits into
ronakv wants to merge 2 commits into
Conversation
- Implement enhanced tooltips with clickable ministry links - Add comprehensive department mapping for federal spending categories - Fix incorrect social security mapping (was Public Safety, now ESDC) - Correct immigration/border security mappings to IRCC - Add sticky tooltip behavior with 300ms delay for better UX - Map economic development agencies to ISED - Add proper ministry name display (e.g., 'Department of National Defence') - Remove direct click functionality on blocks, keep tooltip-based navigation - Fix eslint errors and warnings Closes BuildCanada#108
|
The preview deployment is ready. 🟢 Open Preview | Open Build Logs Last updated at: 2025-07-20 16:36:48 CET |
- Created departmentMap.ts with centralized department name and URL mappings - Refactored SankeyChart.tsx to import and use mappings from config file - Removed hardcoded mapping logic from component - Improved maintainability and code organization
xrendan
self-requested a review
July 20, 2025 17:03
xrendan
requested changes
Jul 20, 2025
xrendan
left a comment
xrendan
left a comment
Member
There was a problem hiding this comment.
@ronakv I get an error when trying to access the sankey diagram at:
https://145.canadaspends.apps.canadasbuilding.com/en/spending
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #108